Repository navigation
Keep unopened iOS previews and drawer panels off the launch path - #262
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed drawers currently mount their hidden sidebar, including its NavigationStack, and the SwiftUI QuickLook preview modifier eagerly links the file-preview framework before any preview request. Both add work before the first content frame.
Keep compact drawer panels unmounted until their first reveal, then retain them across closes. Use UIKit's native document preview on iOS so QuickLook loads when a file is opened; keep the existing macOS preview. Handle dismissal during presentation and suppress duplicate wire dismiss events.
On the same iOS 26 simulator with the same isolated Lambda Journals fixture, five fresh-process Release runs reduced pre-main median from 383ms to 276ms with demand-loaded previews. Deferring the closed drawer reduced view creation median from 217ms to 174ms. These are simulator/local-renderer measurements, not a claim that the full app has reached its 300ms launch target.
Validation:
Run the standalone checks with the commands in platform/apple/Tests/RuntimeChecks/README.md. No XCTest invocation is required.
Based directly on freshly fetched main (9a8de61).