Repository navigation
Fix Android accessible labels and list context menus - #263
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android controls can announce internal test identifiers instead of their explicit labels or visible text. For example, Logseq's Settings action announces
toggle.settings.tab.graphsinstead ofGraphs, on. Keep identifiers intestTag/testTagsAsResourceIdand apply explicit labels in the same semantics modifier, preserving native text semantics when no label is provided.Long-pressing a clickable graph row also activates the row instead of opening its attached context menu. Route that menu through the native Material ListItem long-press callback for ordinary, selected and double-clickable rows. Menu selection closes the popup and emits its action once; short taps, disabled rows and existing long-press actions retain their behavior.
Only two Kotlin renderer files change. No Apple renderer or shared protocol changes are included. The branch starts from Logseq's pinned LUI revision (
52aae863), allowing the application to consume these Android fixes without pulling in unrelated iOS changes.Validation:
Downstream test classes:
AndroidMaterialInteractionTest,AndroidReviewLayoutTestandAndroidListContextMenuTestin Logseq's Android acceptance worktree. The broader downstream acceptance run remains in progress.