Skip to content

Fix Android accessible labels and list context menus - #263

Merged
tiensonqin merged 2 commits into
mainfrom
fix/android-accessibility-labels-20261024
Oct 23, 2026
Merged

tiensonqin merged 2 commits into
mainfrom
fix/android-accessibility-labels-20261024

Conversation

@tiensonqin

@tiensonqin tiensonqin commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Android controls can announce internal test identifiers instead of their explicit labels or visible text. For example, Logseq's Settings action announces toggle.settings.tab.graphs instead of Graphs, on. Keep identifiers in testTag/testTagsAsResourceId and apply explicit labels in the same semantics modifier, preserving native text semantics when no label is provided.

Long-pressing a clickable graph row also activates the row instead of opening its attached context menu. Route that menu through the native Material ListItem long-press callback for ordinary, selected and double-clickable rows. Menu selection closes the popup and emits its action once; short taps, disabled rows and existing long-press actions retain their behavior.

Only two Kotlin renderer files change. No Apple renderer or shared protocol changes are included. The branch starts from Logseq's pinned LUI revision (52aae863), allowing the application to consume these Android fixes without pulling in unrelated iOS changes.

Validation:

  • Three downstream accessibility regressions fail against the original renderer; all 26 affected native layout/interaction tests pass after the label fix.
  • Three real list gesture regressions fail before the menu fix; all five menu cases pass afterward, including disabled rows and existing long-press actions. Short tap, menu selection and reopening are asserted too.
  • All 37 standalone LUI Android JVM tests pass with both changes.

Downstream test classes: AndroidMaterialInteractionTest, AndroidReviewLayoutTest and AndroidListContextMenuTest in Logseq's Android acceptance worktree. The broader downstream acceptance run remains in progress.

@tiensonqin tiensonqin changed the title Fix Android accessibility labels being replaced by test identifiers Fix Android accessible labels and list context menus Oct 23, 2026
@tiensonqin
tiensonqin merged commit f4c9209 into main Oct 23, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant