Repository navigation
Honor Android modal metadata and native dialog actions - #264
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android modal surfaces currently bypass their authored chrome. Dialog and sheet identifiers never reach accessibility, dialog titles and explicit heights are ignored, and a weighted child can stretch a confirmation to the entire screen (840dp in the downstream graph-deletion case).
Apply the common modal modifier, render the authored dialog title, and place direct icon/button children in Material AlertDialog's native slots. Keep the body scrollable so rich content and large text remain reachable, while native action buttons stay outside the scrolling body. Existing rich child layouts remain supported. This changes only the Android Kotlin renderer; no Apple renderer or shared protocol changes are included.
Validation:
Downstream tests:
AndroidModalSurfaceTest,AndroidReviewLayoutTest, andAndroidMaterialInteractionTestin Logseq's Android acceptance worktree.