Skip to content

CONTRIBUTING.md

Latest commit

 

History

History
59 lines (35 loc) · 3.2 KB

CONTRIBUTING.md

File metadata and controls

59 lines (35 loc) · 3.2 KB
Raw

Contributing

Thank you for considering contributing to lomi.! This document will outline how to submit changes to this repository and which conventions to follow. If you are ever in doubt about anything we encourage you to reach out either by submitting an issue here or reaching out hello@lomi.africa or via Discord.

Prerequisites

  • You're familiar with GitHub Issues and Pull Requests
  • You've read the docs.
  • You've setup a test project with bun install lomi.cli

Issues before PRs

  1. Before you start working on a change please make sure that there is an issue for what you will be working on. You can either find and existing issue or open a new issue if none exists. Doing this makes sure that others can contribute with thoughts or suggest alternatives, ultimately making sure that we only add changes that make sense right.

  2. When you are ready to start working on a change you should first fork the repo and branch out from the develop branch.

  3. Make your changes.

  4. Open a pull request towards the develop branch in the lomi. repo. Within a couple of days a lomi. team member will review, comment and eventually approve your PR.

Workflow

Branches

All changes should be part of a branch and submitted as a pull request - your branches should be prefixed with one of:

  • fix/ for bug fixes
  • feat/ for features
  • docs/ for documentation changes

Commits

Strive towards keeping your commits small and isolated - this helps the reviewer understand what is going on and makes it easier to process your requests.

Pull Requests

Once your changes are ready you must submit your branch as a pull request. Your pull request should be opened against the develop branch in the lomi. repo.

In your PR's description you should follow the structure:

  • What - what changes are in this PR
  • Why - why are these changes relevant
  • How - how have the changes been implemented
  • Testing - how has the changes been tested or how can the reviewer test the feature

We highly encourage that you do a self-review prior to requesting a review. To do a self review click the review button in the top right corner, go through your code and annotate your changes. This makes it easier for the reviewer to process your PR.

Merge Style

All pull requests are squashed and merged.

Testing

Much appreciated: all PRs should include tests for the changes that are included. We have two types of tests that must be written:

  • Unit tests found under src/services/__tests__ and /src/api/__tests__

Documentation

  • We generally encourage to document your changes through comments in your code.
  • If you alter user-facing behaviour you must provide documentation for such changes.