Wire Jumbo (lomi. Pos) into monorepo CI, audit, and docs - #87
Open
princemuichkine wants to merge 2 commits into
Open
Wire Jumbo (lomi. Pos) into monorepo CI, audit, and docs#87princemuichkine wants to merge 2 commits into
princemuichkine wants to merge 2 commits into
Conversation
Register the Pos app as a first-class private submodule: dedicated lint/knip/typecheck/Jest CI, dependency audit, task-registry start capability, and docs/README ownership. Co-authored-by: Babacar Diop <princemuichkine@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Drop Prettier and the Jumbo dependency-audit job. The pin fails format on 62 files, and pnpm audit reports high Expo Metro image-size advisories that would turn the weekly security workflow red. Co-authored-by: Babacar Diop <princemuichkine@users.noreply.github.com>
princemuichkine
marked this pull request as ready for review
September 6, 2026 21:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jumbo is already a required private submodule (
apps/jumbo→lomiafrica/jumbo) with Metro/Babel/TS pointed at@lomi./sharedand@lomi./queries. This PR finishes the monorepo-side wiring so it is treated like the other private apps.What
.github/workflows/app-ci-jumbo.yml: checkout the pin, install viatooling/scripts/install-app-with-packages.mjs, then lint, knip,tsc --noEmit, and Jest.starton the Jumbo task-registry entry (script already exists; Expo alias ofdev).main.Why
After the package extract, Jumbo consumed shared packages locally but had no monorepo CI and no public-tree mention. Agents and contributors could not tell it was a first-class app, and package/Metro regressions would not fail the umbrella repo.
How
CI follows the Shopify/plugin pattern:
init-submodules.sh+install-app-with-packages.mjs. Typecheck and Jest are invoked withpnpm execbecause Jumbo’spackage.jsondoes not yet declaretypecheck/testscripts.Prettier and
pnpm auditare intentionally not in this workflow. At pina64ba4e,pnpm formatfails on 62 files, andpnpm audit --audit-level highreports Expo Metroimage-sizeadvisories. Those belong in a Jumbo-repo follow-up, not a red umbrella job.Testing
Verified locally after
node tooling/scripts/install-app-with-packages.mjs apps/jumbo:pnpm lint— pass (15 warnings, 0 errors)pnpm knip— passpnpm exec tsc --noEmit --incremental false— passpnpm exec jest --ci --watchman=false— 14 suites, 42 tests, all passpresenta64ba4e)