Skip to content

Commit 5683e09

Browse files
chore: more zizmor fixes
1 parent dcea19b commit 5683e09

11 files changed

Lines changed: 37 additions & 18 deletions

‎.github/workflows/apix-ci.yml‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,14 @@ on:
2626

2727
workflow_dispatch:
2828

29-
permissions:
30-
checks: write
31-
3229
env:
3330
TS_JUNIT_OUTPUT_DIR: results/apix
3431

3532
jobs:
3633
unit:
3734
name: Unit - ${{ matrix.os }} / Node ${{ matrix.node-version }}
35+
permissions:
36+
checks: write
3837
env:
3938
JEST_JUNIT_OUTPUT_DIR: results/apix
4039
JEST_JUNIT_OUTPUT_NAME: ${{ matrix.os }}.apix${{ matrix.node-version }}.xml

‎.github/workflows/codegen-ci.yml‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,6 @@ on:
2222

2323
workflow_dispatch:
2424

25-
permissions:
26-
checks: write
27-
2825
env:
2926
LOOKERSDK_BASE_URL: https://localhost:20000
3027
LOOKERSDK_VERIFY_SSL: false
@@ -33,6 +30,8 @@ env:
3330
jobs:
3431

3532
unit:
33+
permissions:
34+
checks: write
3635
env:
3736
JEST_JUNIT_OUTPUT_DIR: results/sdk-codegen
3837
JEST_JUNIT_OUTPUT_NAME: ubuntu-latest.sdk-codegen15x.xml
@@ -70,10 +69,12 @@ jobs:
7069
# TODO: can we cache some layers of the image for faster download?
7170
# we probably don't want to cache the final image for IP security...
7271
run: |
73-
docker pull --quiet us-west1-docker.pkg.dev/cloud-looker-sdk-codegen-cicd/looker/${{ fromJson(vars.PRIMARY_LOOKER_VERSION)[0] }}
72+
docker pull --quiet us-west1-docker.pkg.dev/cloud-looker-sdk-codegen-cicd/looker/${PRIMARY_LOOKER_VERSION}
7473
# set $LOOKER_OPTS to --no-ssl if we want to turn off ssl
75-
docker run --name looker-sdk-codegen-ci -d -p 10000:9999 -p 20000:19999 us-west1-docker.pkg.dev/cloud-looker-sdk-codegen-cicd/looker/${{ fromJson(vars.PRIMARY_LOOKER_VERSION)[0] }}
74+
docker run --name looker-sdk-codegen-ci -d -p 10000:9999 -p 20000:19999 us-west1-docker.pkg.dev/cloud-looker-sdk-codegen-cicd/looker/${PRIMARY_LOOKER_VERSION}
7675
docker logs -f looker-sdk-codegen-ci --until=30s &
76+
env:
77+
PRIMARY_LOOKER_VERSION: ${{ fromJson(vars.PRIMARY_LOOKER_VERSION)[0] }}
7778

7879
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
7980
with:

‎.github/workflows/fix-npm.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ name: Fix NPM info
33
on:
44
workflow_dispatch:
55

6+
permissions: {}
7+
68
jobs:
79

810
fix:

‎.github/workflows/go-ci.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ on:
1515
workflow_dispatch:
1616

1717
permissions:
18-
checks: write
18+
contents: read
1919

2020
env:
2121
LOOKERSDK_BASE_URL: https://localhost:20000

‎.github/workflows/lerna-publish.yml‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ on:
1212

1313
jobs:
1414
publish:
15+
permissions:
16+
contents: read
1517
if: >
1618
(github.event.inputs) ||
1719
(startsWith(github.event.release.tag_name, 'sdk-codegen-all') &&
@@ -46,14 +48,17 @@ jobs:
4648

4749
- name: Pull and run Looker docker image
4850
run: |
49-
docker pull --quiet us-west1-docker.pkg.dev/cloud-looker-sdk-codegen-cicd/looker/${{ fromJson(vars.PRIMARY_LOOKER_VERSION)[0] }}
50-
docker run --name looker-sdk-codegen-ci -d -p 10000:9999 -p 20000:19999 us-west1-docker.pkg.dev/cloud-looker-sdk-codegen-cicd/looker/${{ fromJson(vars.PRIMARY_LOOKER_VERSION)[0] }}
51+
docker pull --quiet us-west1-docker.pkg.dev/cloud-looker-sdk-codegen-cicd/looker/${PRIMARY_LOOKER_VERSION}
52+
docker run --name looker-sdk-codegen-ci -d -p 10000:9999 -p 20000:19999 us-west1-docker.pkg.dev/cloud-looker-sdk-codegen-cicd/looker/${PRIMARY_LOOKER_VERSION}
5153
docker logs -f looker-sdk-codegen-ci --until=30s &
54+
env:
55+
PRIMARY_LOOKER_VERSION: ${{ fromJson(vars.PRIMARY_LOOKER_VERSION)[0] }}
5256

5357
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
5458
with:
5559
node-version: 22.x
5660
registry-url: https://wombat-dressing-room.appspot.com
61+
package-manager-cache: false
5762

5863
- name: Install dependencies and build
5964
run: |

‎.github/workflows/python-ci.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ env:
2424
TOX_JUNIT_OUTPUT_DIR: results
2525

2626
permissions:
27-
checks: write
27+
contents: read
2828

2929
jobs:
3030
typecheck:

‎.github/workflows/python-publish.yml‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ defaults:
1616

1717
jobs:
1818
publish:
19+
permissions:
20+
contents: read
1921
if: >
2022
(github.event.inputs) ||
2123
(startsWith(github.event.release.tag_name, 'looker_sdk') &&
@@ -37,8 +39,8 @@ jobs:
3739
pip install wheel
3840
python setup.py sdist bdist_wheel
3941
40-
- uses: pypa/gh-action-pypi-publish@54b39fb9371c0b3a6f9f14bb8a67394defc7a806 # v1.4.1
42+
- uses: pypa/gh-action-pypi-publish@ed0c53931b1dc9bd32cbe73a98c7f6766f8a527e # v1.13.0
4143
with:
4244
user: __token__
43-
password: ${{ secrets.PYPI_API_TOKEN }}
45+
password: ${{ secrets.PYPI_API_TOKEN }} # zizmor: ignore[use-trusted-publishing]
4446
packages_dir: python/dist/

‎.github/workflows/release-metrics.yml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ name: Send publish metrics to bigquery
22
on:
33
release:
44
types: published
5+
6+
permissions: {}
7+
58
jobs:
69
publish:
710
runs-on: ubuntu-latest

‎.github/workflows/release-please.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ on:
77
jobs:
88
release-please:
99
runs-on: ubuntu-latest
10+
permissions:
11+
contents: read
1012
steps:
1113
- uses: google-github-actions/release-please-action@c078ea33917ab8cfa5300e48f4b7e6b16606aede # v3.7.8
1214
with:

‎.github/workflows/required-checks-hack-ci.yml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ jobs:
9292
9393
- name: Debug info
9494
run: |
95-
echo "${{ toJSON(steps.filter.outputs) }}"
95+
echo "${STEPS_FILTER_OUTPUTS}"
9696
echo "apix: ${STEPS_FILTER_OUTPUTS_APIX}"
9797
echo "codegen: ${STEPS_FILTER_OUTPUTS_CODEGEN}"
9898
echo "hackathon: ${STEPS_FILTER_OUTPUTS_HACKATHON}"
@@ -101,6 +101,7 @@ jobs:
101101
echo "tssdk: ${STEPS_FILTER_OUTPUTS_TSSDK}"
102102
echo "gosdk: ${STEPS_FILTER_OUTPUTS_GOSDK}"
103103
env:
104+
STEPS_FILTER_OUTPUTS: ${{ toJSON(steps.filter.outputs) }}
104105
STEPS_FILTER_OUTPUTS_APIX: ${{ steps.filter.outputs.apix }}
105106
STEPS_FILTER_OUTPUTS_CODEGEN: ${{ steps.filter.outputs.codegen }}
106107
STEPS_FILTER_OUTPUTS_HACKATHON: ${{ steps.filter.outputs.hackathon }}

0 commit comments

Comments
 (0)