Repository navigation
Conversation
Previously, `encodeParam` / `encode_path_param` checked whether `decode(value) === value` before URL-encoding. If a parameter value contained both already percent-encoded sequences (such as `%20`) and unencoded reserved characters (such as `+` or `?`), the equality check evaluated to `false` and skipped encoding the remaining reserved characters. This change normalizes the input by decoding first and always URL-encoding the decoded result.
drstrangelooker
approved these changes
Oct 16, 2026
Contributor
Python Tests 10 files 10 suites 1m 1s ⏱️ Results for commit e122331. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
encodeParam/encode_path_paramchecked whetherdecode(value) === valuebefore URL-encoding. If a parameter value contained both already percent-encoded sequences (such as%20) and unencoded reserved characters (such as+or?), the equality check evaluated tofalseand skipped encoding the remaining reserved characters.This change normalizes the input by decoding first and always URL-encoding the decoded result.