Commit 96ad2f7
fix(design-drift): the member parser ate the comma, so every per-file check was blind
`pnpm design:drift` reported 18 fail on the merged tree. The real number is 98.
The difference was not progress — it was the checker failing to look.
parseMemberList matched each frontmatter field with `(\S+)`, which is greedy
across the comma separating them. `path: shell, prefix: …` therefore yielded the
path "shell,", and resolve(REPO_ROOT, "shell,", "src") does not exist. So
findMemberFiles returned an empty array for all nineteen members, and every
check that walks member files — F8 hardcoded hex and box-shadow, F4 raw z-index,
F1a Tier-1 consumption, leaked selectors — found nothing to inspect and passed.
The failure was well disguised. The one check that still fired was F6, whose
own path resolution broke the same way, so it failed for every member — and "no
DESIGN.md at member root" reads as Phase 8 work not yet done, not as an
instrument that cannot see the tree. A near-clean report with a plausible
explanation for its only failures.
This is the exact failure mode the Phase 1 handoff warned about in its own
notes: a checker reporting success because it failed to look. It warned about
two instances (an argv off-by-one and a CRLF read) and this is a third.
Each field now stops at the comma, and root_class is stripped of the quotes it
carries. With the parser fixed: 98 fail · 0 warn — 59 F8, 21 F4, 17 F6, 1 P2.
Not reconciled: the Phase 1 handoff reports 480 fail · 212 warn and 108/108
contrast pairs, against 98 · 0 and 30/30 here. The parser fix accounts for the
18 → 98 jump but not the rest, and the contrast pair count is a separate
question. Flagged on the PR rather than guessed at — those figures were measured
on another machine and their author should confirm what they counted.
Files changed:
- scripts/design-drift.mjs
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019a8tSPbFdvF1pKtADnWyDg1 parent 4285ec2 commit 96ad2f7
1 file changed
Lines changed: 20 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
94 | | - | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
95 | 108 | | |
96 | | - | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
97 | 115 | | |
98 | 116 | | |
99 | 117 | | |
| |||
0 commit comments