Commit b295817
fix(shell): the shell's typecheck has never passed — missing css shim and a wrong element type
`pnpm --filter @augment-it/shell check` failed with two errors, and had done
since the check script was written. Both are now fixed and the shell typechecks
clean for the first time.
The missing CSS shim had a root cause worth naming. shell/src/index.ts does a
side-effect import of '@augment-it/theme/theme.css', which carries no type
declarations — rsbuild resolves it at build time, but svelte-check cannot.
Every app under apps/ ships a src/css.d.ts declaring `*.css` ambiently. The
shell never did, and adding one would not have helped: shell/tsconfig.json was
a byte-identical copy of the apps' old drifted variant, and that variant omits
"src/**/*.d.ts" from `include`, so the shim would have been ignored. Both
halves are fixed together — the shim exists, and the shell now extends
tsconfig.base.json like the apps do.
That makes the shell the eighteenth copy of the config converged earlier today,
found only because this bug pointed at it. Its tsconfig drops from 20 lines to
4.
The second error was a real type mismatch rather than a config artifact.
`stageEl` was declared HTMLDivElement but is bound to `<main class="stage">`,
which is an HTMLElement. Widened to HTMLElement, which is safe: the only member
ever called on it is getBoundingClientRect(). Annotation-only — no runtime
change, and the built output is unaffected.
Verified: shell 93 files clean, and 1,587 files across all seventeen apps plus
the shell now check with zero errors, up from 1,494 with the shell failing
outright. 19 packages build.
Files changed:
- shell/src/css.d.ts (new)
- shell/tsconfig.json
- shell/src/App.svelte
- tsconfig.base.json
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019a8tSPbFdvF1pKtADnWyDg1 parent 45047cf commit b295817
4 files changed
Lines changed: 16 additions & 20 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
196 | 196 | | |
197 | 197 | | |
198 | 198 | | |
199 | | - | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
200 | 202 | | |
201 | 203 | | |
202 | 204 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
| 2 | + | |
| 3 | + | |
20 | 4 | | |
21 | 5 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
0 commit comments