refactor(shell, corpora-curator): Phase 5 — drop the legacy env-var reads, the rename now runs end to end

The two-name window existed because Railway supplied the STRATEGY_CURATOR
spellings and both vars are inlined at build time. Railway now supplies only the
CORPORA_CURATOR names and the legacy variables are deleted, so the middle term
in each fallback chain is dead weight. All four files read one name.

The infrastructure half of the rename was executed at the same time, against a
project with no active users and a remote database, so the additive-domain
dance in the plan was skipped for a straight cut: dockerfilePath and build
command repointed at apps/corpora-curator, the service renamed, the old
generated domain deleted and a new one generated, both PUBLIC_CORPORA_CURATOR_*
variables set, both PUBLIC_STRATEGY_CURATOR_* variables deleted, and the stale
RAILPACK_STATIC_FILE_ROOT corrected.

Two things worth recording, both now in the refactor doc. A generated domain
does NOT follow a service rename — it is its own object with its own ID, the
service kept serving the old hostname after being renamed, and generate_domain
is a no-op while any domain exists, so it has to be deleted and regenerated.
And no Railway MCP tool renames a service; the CLI's `railway api` GraphQL
passthrough does it via serviceUpdate, without the agent ever handling the auth
token.

`STRATEGY_CURATOR` now appears nowhere in the tree outside changelog entries,
DESIGN.md's historical revisions, and the refactor doc that records the
transition — all deliberate.

Verified with a real docker build of the shell and corpora-curator images after
the edits; both green.

Files changed:
- shell/rsbuild.config.ts, shell/Dockerfile
- apps/corpora-curator/rsbuild.config.ts, apps/corpora-curator/Dockerfile
- context-v/refactors/Rename-Strategy-Curator-To-Corpora-Curator.md — the
  sequence marked executed, plus the domain and MCP-gap findings

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PZJvZWco3z7SR2dEhFqEjA

Author: mpstaton

apps/corpora-curator/Dockerfile

@@ -24,12 +24,9 @@ RUN pnpm install --frozen-lockfile
 ARG PUBLIC_WS_URL
 ARG PUBLIC_ID_BASE
 ARG PUBLIC_CORPORA_CURATOR_ASSET_PREFIX
-# Rename transition: Railway still passes the old name. Drop in Phase 5.
-ARG PUBLIC_STRATEGY_CURATOR_ASSET_PREFIX
 ENV PUBLIC_WS_URL=$PUBLIC_WS_URL
 ENV PUBLIC_ID_BASE=$PUBLIC_ID_BASE
 ENV PUBLIC_CORPORA_CURATOR_ASSET_PREFIX=$PUBLIC_CORPORA_CURATOR_ASSET_PREFIX
-ENV PUBLIC_STRATEGY_CURATOR_ASSET_PREFIX=$PUBLIC_STRATEGY_CURATOR_ASSET_PREFIX
 RUN pnpm --filter @augment-it/corpora-curator build
 
 FROM node:22-alpine

apps/corpora-curator/rsbuild.config.ts

@@ -10,14 +10,10 @@ import { pluginModuleFederation } from '@module-federation/rsbuild-plugin';
 // the full rationale (a federated remote's sub-chunks resolve against
 // whatever assetPrefix it was compiled with, not the host's origin;
 // dev.assetPrefix alone doesn't cover production builds).
-// RENAME TRANSITION (Phase 4): the Railway service still passes the
-// STRATEGY_CURATOR name. Missing this one does not fail the build — it ships a
-// remote that loads and then breaks on its first async sub-chunk, because the
-// prefix falls back to localhost. Legacy name read second; drop it in Phase 5.
-const ASSET_PREFIX =
-  process.env.PUBLIC_CORPORA_CURATOR_ASSET_PREFIX ||
-  process.env.PUBLIC_STRATEGY_CURATOR_ASSET_PREFIX ||
-  'http://localhost:3017';
+// Missing this does not fail the build — it ships a remote that loads and then
+// breaks on its first async sub-chunk, because the prefix falls back to
+// localhost. `||` not `??`: an unset Docker ARG arrives as an empty string.
+const ASSET_PREFIX = process.env.PUBLIC_CORPORA_CURATOR_ASSET_PREFIX || 'http://localhost:3017';
 
 export default defineConfig({
   plugins: [

context-v/refactors/Rename-Strategy-Curator-To-Corpora-Curator.md

@@ -128,35 +128,51 @@ Only **two** of the seventeen remotes are deployed at all — the curator and
 `chat`; the other fifteen are still pointed at `localhost` in the shell's
 federation config, deliberately, per the build order.
 
-### The transition fallbacks already in the tree
+### The transition fallbacks — added in Phase 4, removed in Phase 5
 
-Because these vars are inlined at **build** time, a build that lands before the
-dashboard is updated would fall through to `localhost` and 404 in production.
-Four files therefore read the **new** name first and the **old** name second:
+Because these vars are inlined at **build** time, a build that landed before the
+dashboard was updated would have fallen through to `localhost` and 404'd in
+production. Four files therefore read the **new** name first and the **old**
+name second for the length of the transition.
+
+**That window is now closed** (2026-08-15). Railway supplies only the
+`CORPORA_CURATOR` names, the legacy variables are deleted, and all four files
+read a single name:
 
 | File | Reads |
 |---|---|
-| `shell/rsbuild.config.ts` | `PUBLIC_CORPORA_CURATOR_REMOTE` ‖ `PUBLIC_STRATEGY_CURATOR_REMOTE` |
-| `shell/Dockerfile` | both `ARG`/`ENV` declared |
-| `apps/corpora-curator/rsbuild.config.ts` | `PUBLIC_CORPORA_CURATOR_ASSET_PREFIX` ‖ `PUBLIC_STRATEGY_CURATOR_ASSET_PREFIX` |
-| `apps/corpora-curator/Dockerfile` | both `ARG`/`ENV` declared |
+| `shell/rsbuild.config.ts` | `PUBLIC_CORPORA_CURATOR_REMOTE` |
+| `shell/Dockerfile` | one `ARG`/`ENV` |
+| `apps/corpora-curator/rsbuild.config.ts` | `PUBLIC_CORPORA_CURATOR_ASSET_PREFIX` |
+| `apps/corpora-curator/Dockerfile` | one `ARG`/`ENV` |
 
-This means **the current tree deploys correctly with the dashboard untouched.**
-The asset-prefix one matters most: missing it does not fail the build, it ships
+The asset-prefix one mattered most: missing it does not fail the build, it ships
 a remote that loads and then breaks on its first async sub-chunk.
 
-### Sequence
-
-1. Update the Railway service's `dockerfilePath` to
-   `apps/corpora-curator/Dockerfile`. Dashboard change; Railway builds on push,
-   so land it near the merge. Out of order in either direction costs one failed
-   build — recoverable, but expect it rather than discover it.
-2. Add `corpora-curator-production.up.railway.app` as an **additional** domain
-   on the existing service. Both hostnames now serve.
-3. Add `PUBLIC_CORPORA_CURATOR_REMOTE` / `PUBLIC_CORPORA_CURATOR_ASSET_PREFIX`
-   as service variables, redeploy, verify in a real browser.
-4. Only then rename the Railway service and retire the old domain.
-5. Update `DEPLOYMENT.md`'s hostname table last, once it is true.
+### Sequence — executed 2026-08-15
+
+The plan below was written expecting a careful dashboard dance. It was executed
+instead against a project with **no active users and a remote database**, where
+downtime was explicitly acceptable, so the additive-domain step was skipped in
+favour of a straight cut.
+
+| # | Step | Result |
+|---|---|---|
+| 1 | `dockerfilePath` → `apps/corpora-curator/Dockerfile`, build command → `pnpm --filter @augment-it/corpora-curator build` | ✅ |
+| 2 | Rename the Railway service `strategy-curator` → `corpora-curator` | ✅ via `serviceUpdate` — **no MCP tool covers this**; the Railway CLI's `railway api` GraphQL passthrough does |
+| 3 | Old generated domain deleted, new one generated | ✅ `corpora-curator-production.up.railway.app` |
+| 4 | `PUBLIC_CORPORA_CURATOR_*` set on both services; `PUBLIC_STRATEGY_CURATOR_*` deleted; `RAILPACK_STATIC_FILE_ROOT` corrected | ✅ |
+| 5 | Phase 5 — legacy reads dropped from all four files | ✅ |
+| 6 | `DEPLOYMENT.md` hostname table | ✅ already correct — Phase 1 wrote the post-rename hostname, which only became true at step 3 |
+
+**A generated domain does not follow a service rename.** After renaming, the
+service still served `strategy-curator-production.up.railway.app`. The domain is
+its own object with its own ID; it must be deleted and regenerated, and
+`generate_domain` is a no-op while any domain already exists.
+
+**`RAILWAY_PRIVATE_DOMAIN` still reads `strategy-curator.railway.internal`** —
+Railway-managed, expected to refresh on the next successful deploy. Nothing
+in this repo consumes it (private networking is unused between the frontends).
 
 ## 6. Phase 5 — retire
 

shell/Dockerfile

@@ -26,16 +26,13 @@ RUN pnpm install --frozen-lockfile
 ARG PUBLIC_WS_URL
 ARG PUBLIC_ID_BASE
 ARG PUBLIC_CORPORA_CURATOR_REMOTE
-# Rename transition: Railway still passes the old name. Drop in Phase 5.
-ARG PUBLIC_STRATEGY_CURATOR_REMOTE
 ARG PUBLIC_CHAT_REMOTE
 ARG PUBLIC_ORG_WORKBENCH_REMOTE
 ARG PUBLIC_SEARCH_AND_ADD_REMOTE
 ARG PUBLIC_SEARCH_RESULTS_REMOTE
 ENV PUBLIC_WS_URL=$PUBLIC_WS_URL
 ENV PUBLIC_ID_BASE=$PUBLIC_ID_BASE
 ENV PUBLIC_CORPORA_CURATOR_REMOTE=$PUBLIC_CORPORA_CURATOR_REMOTE
-ENV PUBLIC_STRATEGY_CURATOR_REMOTE=$PUBLIC_STRATEGY_CURATOR_REMOTE
 ENV PUBLIC_CHAT_REMOTE=$PUBLIC_CHAT_REMOTE
 ENV PUBLIC_ORG_WORKBENCH_REMOTE=$PUBLIC_ORG_WORKBENCH_REMOTE
 ENV PUBLIC_SEARCH_AND_ADD_REMOTE=$PUBLIC_SEARCH_AND_ADD_REMOTE

shell/rsbuild.config.ts

@@ -23,16 +23,8 @@ import { pluginModuleFederation } from '@module-federation/rsbuild-plugin';
 // produced "TypeError: object null is not iterable" deep in rspack's
 // Module Federation remote-info resolution — an empty remote URL, not a
 // missing one.
-// RENAME TRANSITION (corpora-curator, Phase 4). The deployed Railway service
-// still supplies PUBLIC_STRATEGY_CURATOR_REMOTE, and this var is inlined at
-// BUILD time — so a shell built after the rename but before the dashboard is
-// updated would silently fall through to localhost and 404 in production.
-// Reading the legacy name second keeps both worlds building.
-// DELETE the middle term in Phase 5, once Railway supplies the new name.
 const CORPORA_CURATOR_REMOTE =
-  process.env.PUBLIC_CORPORA_CURATOR_REMOTE ||
-  process.env.PUBLIC_STRATEGY_CURATOR_REMOTE ||
-  'http://localhost:3017/remoteEntry.js';
+  process.env.PUBLIC_CORPORA_CURATOR_REMOTE || 'http://localhost:3017/remoteEntry.js';
 const CHAT_REMOTE = process.env.PUBLIC_CHAT_REMOTE || 'http://localhost:3006/remoteEntry.js';
 // Augment-from-DB remotes — deployed for the reach-edu opening (#69);
 // localhost fallbacks keep local dev unchanged.