Skip to content

Commit f8ed24b

Browse files
mpstatonclaude
andcommitted
fix(tsconfig): drop deprecated baseUrl so shared-ui components compile under TypeScript 6
TypeScript 6 deprecates baseUrl (TS5101), and svelte-preprocess promotes that deprecation into a hard build error. It only bit the two apps that import packages/shared-ui components - shared-ui has no tsconfig of its own, so svelte-preprocess walks up to the ROOT tsconfig (the one with baseUrl) when compiling ConfidencePill.svelte and ToggleHeader__PromptOrPackage--Icons.svelte, failing the shell and response-reviewer dev builds. Apps that don't pull in shared-ui compiled against their own baseUrl-free tsconfigs and never noticed. Fix is the TS6-idiomatic one, not the ignoreDeprecations escape hatch: remove baseUrl and let paths resolve relative to the tsconfig, which the root config's ./-prefixed paths already did. splash/tsconfig.json gets the same treatment with its paths entries ./-prefixed to match. Verified: shell and response-reviewer rsbuild builds are clean, and the tree-wide typecheck stays green. Files changed: - tsconfig.json - splash/tsconfig.json TS6 upgrade fallout from 68670bc, surfaced by the first dev-server run since. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent 265f391 commit f8ed24b

2 files changed

Lines changed: 8 additions & 10 deletions

File tree

splash/tsconfig.json

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,15 @@
33
"include": [".astro/types.d.ts", "**/*"],
44
"exclude": ["dist"],
55
"compilerOptions": {
6-
"baseUrl": ".",
76
"paths": {
8-
"@/*": ["src/*"],
9-
"@components/*": ["src/components/*"],
10-
"@layouts/*": ["src/layouts/*"],
11-
"@loaders/*": ["src/loaders/*"],
12-
"@lib/*": ["src/lib/*"],
13-
"@styles/*": ["src/styles/*"],
14-
"@content/*": ["src/content/*"],
15-
"@pages/*": ["src/pages/*"]
7+
"@/*": ["./src/*"],
8+
"@components/*": ["./src/components/*"],
9+
"@layouts/*": ["./src/layouts/*"],
10+
"@loaders/*": ["./src/loaders/*"],
11+
"@lib/*": ["./src/lib/*"],
12+
"@styles/*": ["./src/styles/*"],
13+
"@content/*": ["./src/content/*"],
14+
"@pages/*": ["./src/pages/*"]
1615
}
1716
}
1817
}

tsconfig.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
"strict": true,
1515
"noUnusedLocals": true,
1616
"noUnusedParameters": true,
17-
"baseUrl": ".",
1817
"paths": {
1918
"@/*": ["./src/*"],
2019
"@packages/*": ["./packages/*/src"],

0 commit comments

Comments
 (0)