Skip to content

Feat: real time video show #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArthurLobopro wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Feat: real time video show #94

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
889b2fb
feat: show video while set playbackRate
ArthurLobopro Mar 2, 2025
8ab6ba1
fix: use default when speed is 0
ArthurLobopro Mar 3, 2025
5e75ffd
fix: alow to view and edit unabled videos
ArthurLobopro Mar 3, 2025
ef7bce1
fix: stop playback after closing video settings dialog
luisbocanegra Mar 4, 2025
e93b805
fix: stop playback after closing video settings dialog
luisbocanegra Mar 4, 2025
3a94b0a
Merge branch 'feat-real-time-video-show' of https://github.com/Arthur…
ArthurLobopro Mar 4, 2025
f1a45e8
fix: destroy videoplayer after close
ArthurLobopro Mar 4, 2025
7ed8195
fix: calls gabarge collector to reduce memory usage
ArthurLobopro Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 83 additions & 35 deletions package/contents/ui/config.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,18 +199,20 @@ Kirigami.FormLayout {
Utils.updateConfig()
}
}
Button {
icon.name: "preferences-other"
enabled: true
onClicked: {
dialogPlaybackRateSpeed.value = videosConfig[modelData].playbackRate
videoConfig.filename = videosConfig[modelData].filename
videoConfig.index = index
videoConfig.open()
}
}

Button {
icon.name: "preferences-other"
enabled: true
onClicked: {
dialogPlaybackRateSpeed.value = videosConfig[modelData].playbackRate
videoConfig.filename = videosConfig[modelData].filename
videoConfig.index = index
videoConfig.open()
}
}
Button{

Button {
icon.name: "edit-delete-remove"
onClicked: {
videosConfig.splice(index,1)
Expand Down Expand Up @@ -709,41 +711,87 @@ Kirigami.FormLayout {
property real speed
property string filename: ""

Kirigami.FormLayout {
RowLayout {
Kirigami.FormData.label: i18n("Playback speed:")
Slider {
id: dialogPlaybackRateSpeed
from: 0
to: 2
value: videoConfig.speed
onValueChanged: {
videoConfig.speed = value
onOpened: {
videoPlayer.player = Qt.createQmlObject(`
import QtMultimedia

Video {
id: videoPlayer
anchors.fill: parent
loops: MediaPlayer.Infinite
source: ""
autoPlay: true
}`,
videoPlayer
)

videoPlayer.player.source = videoConfig.filename
videoPlayer.player.playbackRate = videoConfig.speed || cfg_PlaybackRate
}

onSpeedChanged: {
videoPlayer.player.playbackRate = videoConfig.speed || cfg_PlaybackRate
}

Column {
Rectangle {
//Mini 16/9
width: 400
height: 236
color: "transparent"

id: videoPlayer

property var player
}

Kirigami.FormLayout {
RowLayout {
Kirigami.FormData.label: i18n("Playback speed:")
Slider {
id: dialogPlaybackRateSpeed
from: 0
to: 2
value: videoConfig.speed
onValueChanged: {
videoConfig.speed = value
}
}
}
Label {
text: parseFloat(dialogPlaybackRateSpeed.value).toFixed(2)
font.features: { "tnum": 1 }
}
Button {
icon.name: "edit-undo-symbolic"
flat: true
onClicked: {
dialogPlaybackRateSpeed.value = 0.0
Label {
text: parseFloat(dialogPlaybackRateSpeed.value).toFixed(2)
font.features: { "tnum": 1 }
}
Button {
icon.name: "edit-undo-symbolic"
flat: true
onClicked: {
dialogPlaybackRateSpeed.value = 0.0
}
ToolTip.text: i18n("Reset to default")
ToolTip.visible: hovered
}
Kirigami.ContextualHelpButton {
toolTipText: i18n("A value other than 0.0 overrides the global Playback speed for this video.")
}
ToolTip.text: i18n("Reset to default")
ToolTip.visible: hovered
}
Kirigami.ContextualHelpButton {
toolTipText: i18n("A value other than 0.0 overrides the global Playback speed for this video.")
}
}
}

function destroyVideoPlayer(){
videoPlayer.player.destroy()
videoPlayer.player = null
gc()
}

onAccepted: {
videosConfig[index].playbackRate = speed
destroyVideoPlayer()
Utils.updateConfig()
}

onRejected: {
destroyVideoPlayer()
}
}

Component.onCompleted: {
Expand Down