fix: dont warn when no remote tags exist - #102
Merged
Merged
Conversation
My logs were full of scary warnings "Could not parse latest tag from ..". turns out if a remote repo has no tags, we were trying to decode an empty string `parser.parse_git_latest_semver_tag(sc.stdout or "")`. I special cased the empty-string (ie, no remote tags) so it appears as a debug level. ok
else jujutsu autotracks it
teto
force-pushed
the
teto/dont-warn-on-empty-tags
branch
from
July 27, 2026 17:11
df0f2a4 to
8a1add7
Compare
mrcjkb
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My logs were full of scary warnings "Could not parse latest tag from
..".
turns out if a remote repo has no tags, we were trying to decode an
empty string
parser.parse_git_latest_semver_tag(sc.stdout or "").I special cased the empty-string (ie, no remote tags) so it appears as a debug level.
The test was not necessary but I added it while debugging and it doesn't hurt to have it.
I still have illegitimate failures I intend to fix as follow up