arch(config): introduce LV_COLOR_FORMAT_DEFAULT and deprecate LV_COLOR_DEPTH

[AndreCostaaa]

No description provided.

[cubic-dev-ai]

2 issues found and verified against the latest diff

_{You’re at about 95% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.}

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="Kconfig">

<violation number="1" location="Kconfig:265">
P1: When any Kconfig format other than RGB565 is selected, Kconfig emits the member symbol but no `CONFIG_LV_COLOR_FORMAT_DEFAULT`, so `lv_conf_internal.h` silently falls back to RGB565. Add a Kconfig-to-header bridge or derive the macro from the selected `LV_COLOR_FORMAT_*` member before relying on this named choice.</violation>
</file>

<file name="scripts/generators/config_headers/kconfig_utils.py">

<violation number="1" location="scripts/generators/config_headers/kconfig_utils.py:205">
P1: When this helper processes the bundled kconfiglib symbols, `sym.defaults` entries contain a source-location field, so the two-value unpack raises before `LV_COLOR_DEPTH` can be classified. Unpack the optional location field as well.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P1: When any Kconfig format other than RGB565 is selected, Kconfig emits the member symbol but no CONFIG_LV_COLOR_FORMAT_DEFAULT, so lv_conf_internal.h silently falls back to RGB565. Add a Kconfig-to-header bridge or derive the macro from the selected LV_COLOR_FORMAT_* member before relying on this named choice.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At Kconfig, line 265:

<comment>When any Kconfig format other than RGB565 is selected, Kconfig emits the member symbol but no `CONFIG_LV_COLOR_FORMAT_DEFAULT`, so `lv_conf_internal.h` silently falls back to RGB565. Add a Kconfig-to-header bridge or derive the macro from the selected `LV_COLOR_FORMAT_*` member before relying on this named choice.</comment>

<file context>
@@ -261,10 +261,46 @@ endmenu
-		prompt "Color depth"
-		default LV_COLOR_DEPTH_16
 
+	choice LV_COLOR_FORMAT_DEFAULT
+		prompt "Default color format"
+		default LV_COLOR_FORMAT_I1       if LV_COLOR_DEPTH_1
</file context>

[cubic-dev-ai]

P1: When this helper processes the bundled kconfiglib symbols, sym.defaults entries contain a source-location field, so the two-value unpack raises before LV_COLOR_DEPTH can be classified. Unpack the optional location field as well.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At scripts/generators/config_headers/kconfig_utils.py, line 205:

<comment>When this helper processes the bundled kconfiglib symbols, `sym.defaults` entries contain a source-location field, so the two-value unpack raises before `LV_COLOR_DEPTH` can be classified. Unpack the optional location field as well.</comment>

<file context>
@@ -165,6 +166,102 @@ def int_const_value(sym) -> str:
+    table: dict[str, str] = {}
+    fallback = None
+
+    for value, cond in sym.defaults:
+        literal = _literal_value(value)
+        if literal is None:
</file context>

Suggested change

	for value, cond in sym.defaults:
	for value, cond, *_ in sym.defaults:

[github-actions]

Hi 👋, thank you for your PR!

We've run benchmarks in an emulated environment. Here are the results:

ARM Emulated 32b - lv_conf_perf32b

Scene Name	Avg CPU (%)	Avg FPS	Avg Time (ms)	Render Time (ms)	Flush Time (ms)
All scenes avg.	101	38 (-2)	24 (+5)	24 (+5)	0

Detailed Results Per Scene

Scene Name	Avg CPU (%)	Avg FPS	Avg Time (ms)	Render Time (ms)	Flush Time (ms)
Empty screen	101	44	7	7	0
Moving wallpaper	101	14 (-36)	70 (+51)	70 (+51)	0
Single rectangle	101	49	0	0	0
Multiple rectangles	101	49	4 (+1)	4 (+1)	0
Multiple RGB images	101	46 (-2)	16 (+12)	16 (+12)	0
Multiple ARGB images	101	49	13 (+1)	13 (+1)	0
Rotated ARGB images	101	25	37 (-1)	37 (-1)	0
Multiple labels	101	60 (+1)	13	13	0
Screen sized text	101	24	39	39	0
Multiple arcs	101	41 (-1)	21	21	0
Containers	101	48 (-1)	5	5	0
Containers with overlay	101	14	68 (+1)	68 (+1)	0
Containers with opa	101	48 (-1)	12 (-1)	12 (-1)	0
Containers with opa_layer	101	43	20 (+2)	20 (+2)	0
Containers with scrolling	101	31	30	30	0
Widgets demo	101	30	30	30	0
All scenes avg.	101	38 (-2)	24 (+5)	24 (+5)	0

ARM Emulated 64b - lv_conf_perf64b

Scene Name	Avg CPU (%)	Avg FPS	Avg Time (ms)	Render Time (ms)	Flush Time (ms)
All scenes avg.	101	39 (-3)	21 (+3)	21 (+3)	0

Detailed Results Per Scene

Scene Name	Avg CPU (%)	Avg FPS	Avg Time (ms)	Render Time (ms)	Flush Time (ms)
Empty screen	101	44	7	7	0
Moving wallpaper	101	17 (-33)	56 (+37)	56 (+37)	0
Single rectangle	101	49	0	0	0
Multiple rectangles	101	49	3	3	0
Multiple RGB images	101	49	14 (+10)	14 (+10)	0
Multiple ARGB images	101	49	13 (+1)	13 (+1)	0
Rotated ARGB images	101	43 (-2)	21 (+1)	21 (+1)	0
Multiple labels	101	50 (-1)	13	13	0
Screen sized text	101	24	39	39	0
Multiple arcs	101	44	19	19	0
Containers	101	49	4	4	0
Containers with overlay	101	15 (+1)	62 (-2)	62 (-2)	0
Containers with opa	101	49 (-1)	12	12	0
Containers with opa_layer	101	45 (-2)	16 (+2)	16 (+2)	0
Containers with scrolling	101	32	29	29	0
Widgets demo	101	31	29	29	0
All scenes avg.	101	39 (-3)	21 (+3)	21 (+3)	0

Disclaimer: These benchmarks were run in an emulated environment using QEMU with instruction counting mode.
The timing values represent relative performance metrics within this specific virtualized setup and should
not be interpreted as absolute real-world performance measurements. Values are deterministic and useful for
comparing different LVGL features and configurations, but may not correlate directly with performance on
physical hardware. The measurements are intended for comparative analysis only.

---

🤖 This comment was automatically generated by a bot.