feat(rsbuild-plugin): apply the build engine for rslib - #3696
Conversation
🦋 Changeset detectedLatest commit: a99556e The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
background-only
@lynx-js/use-sync-external-store
@lynx-js/rspeedy
create-rspeedy
@lynx-js/debug-metadata-rsbuild-plugin
@lynx-js/rsbuild-plugin
@lynx-js/react-rsbuild-plugin
@lynx-js/react-alias-rsbuild-plugin
@lynx-js/vanilla-rsbuild-plugin
upgrade-rspeedy
@lynx-js/websocket
@lynx-js/css-serializer
@lynx-js/debug-metadata
@lynx-js/web-core
@lynx-js/web-elements
@lynx-js/web-rsbuild-server-middleware
@lynx-js/web-worker-rpc
@lynx-js/cache-events-webpack-plugin
@lynx-js/chunk-loading-webpack-plugin
@lynx-js/css-extract-webpack-plugin
@lynx-js/react-refresh-webpack-plugin
@lynx-js/react-webpack-plugin
@lynx-js/runtime-wrapper-webpack-plugin
@lynx-js/template-webpack-plugin
@lynx-js/webpack-dev-transport
@lynx-js/webpack-runtime-globals
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merging this PR will degrade performance by 1.1%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | basic-performance-div-1000 |
5.5 ms | 8.4 ms | -34.23% |
| ⚡ | WallTime | basic-performance-text-200 |
3.5 ms | 2.8 ms | +26.41% |
| ⚡ | WallTime | basic-performance-scroll-view-100 |
2.1 ms | 2 ms | +7.45% |
| ⚡ | WallTime | basic-performance-image-100 |
2 ms | 1.8 ms | +7.09% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing feat/rslib-auto-lynx (a99556e) with fix/auto-lynx-per-environment (08fa6ae)
Footnotes
-
26 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
React MTF Example#5008 Bundle Size — 210.55KiB (0%).6717276(current) vs 08fa6ae fix/auto-lynx-per-environment#4994(baseline) Bundle metrics
|
| Current #5008 |
Baseline #4994 |
|
|---|---|---|
0B |
0B |
|
0B |
0B |
|
0% |
0% |
|
0 |
0 |
|
3 |
3 |
|
215 |
215 |
|
82 |
82 |
|
42.99% |
42.99% |
|
2 |
2 |
|
0 |
0 |
Bundle size by type no changes
| Current #5008 |
Baseline #4994 |
|
|---|---|---|
111.23KiB |
111.23KiB |
|
99.32KiB |
99.32KiB |
Bundle analysis report Branch feat/rslib-auto-lynx Project dashboard
Generated by RelativeCI Documentation Report issue
Web Explorer#13480 Bundle Size — 1.29MiB (0%).a99556e(current) vs 08fa6ae fix/auto-lynx-per-environment#13463(baseline) Bundle metrics
Bundle size by type
|
| Current #13480 |
Baseline #13463 |
|
|---|---|---|
756.75KiB |
756.75KiB |
|
564.93KiB |
564.93KiB |
|
2.37KiB |
2.37KiB |
Bundle analysis report Branch feat/rslib-auto-lynx Project dashboard
Generated by RelativeCI Documentation Report issue
React Example#11897 Bundle Size — 239.07KiB (0%).a99556e(current) vs 08fa6ae fix/auto-lynx-per-environment#11877(baseline) Bundle metrics
|
| Current #11897 |
Baseline #11877 |
|
|---|---|---|
0B |
0B |
|
0B |
0B |
|
0% |
0% |
|
0 |
0 |
|
4 |
4 |
|
220 |
220 |
|
85 |
85 |
|
43.55% |
43.55% |
|
2 |
2 |
|
0 |
0 |
Bundle size by type no changes
| Current #11897 |
Baseline #11877 |
|
|---|---|---|
145.76KiB |
145.76KiB |
|
93.32KiB |
93.32KiB |
Bundle analysis report Branch feat/rslib-auto-lynx Project dashboard
Generated by RelativeCI Documentation Report issue
React Example with Element Template#4152 Bundle Size — 227.26KiB (0%).a99556e(current) vs 08fa6ae fix/auto-lynx-per-environment#4134(baseline) Bundle metrics
|
| Current #4152 |
Baseline #4134 |
|
|---|---|---|
0B |
0B |
|
0B |
0B |
|
0% |
0% |
|
0 |
0 |
|
4 |
4 |
|
175 |
175 |
|
62 |
62 |
|
36.46% |
36.46% |
|
2 |
2 |
|
0 |
0 |
Bundle size by type no changes
| Current #4152 |
Baseline #4134 |
|
|---|---|---|
145.76KiB |
145.76KiB |
|
81.5KiB |
81.5KiB |
Bundle analysis report Branch feat/rslib-auto-lynx Project dashboard
Generated by RelativeCI Documentation Report issue
React External#4991 Bundle Size — 583.94KiB (~+0.01%).6717276(current) vs 08fa6ae fix/auto-lynx-per-environment#4977(baseline) Bundle metrics
Bundle size by type
Bundle analysis report Branch feat/rslib-auto-lynx Project dashboard Generated by RelativeCI Documentation Report issue |
d6a79d1 to
64bcbf6
Compare
64bcbf6 to
db3dce7
Compare
| // A test run emits nothing, so the engine has nothing to add. `rslib` | ||
| // does emit a bundle and reads the engine config, so the engine is | ||
| // applied for it; `pluginLynx` leaves out the plugins that would rewrite | ||
| // what an external bundle assembles itself. |
There was a problem hiding this comment.
Just remove verbose comments
db3dce7 to
491716d
Compare
491716d to
6154f41
Compare
325941e to
d7102ca
Compare
3bea4ff to
6be7738
Compare
6be7738 to
ebac7bd
Compare
ebac7bd to
107779c
Compare
107779c to
9c8ff9a
Compare
ebc517a to
97544b6
Compare
6f622a1 to
1e5d5b1
Compare
1e5d5b1 to
6723467
Compare
125461e to
6717276
Compare
`rslib` was left out of the engine entirely, so a library build read none of the Lynx config and had to mirror the parts it needed by hand. Apply the engine there too, and skip the plugins that shape or serve a bundle: `rslib` assembles its own, and `rstest` has none.
6717276 to
a99556e
Compare
rslibwas left out of the engine entirely, so a library build read none of theLynx config and had to mirror the parts it needed by hand.
Apply the engine there too, and skip the plugins that shape or serve a bundle:
rslibassembles its own, andrstesthas none.