Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for Arduino-ESP32 3.3.11 while preserving the existing Arduino-ESP32 2.x build environment and runtime behavior.
The update addresses API and driver changes introduced in Arduino-ESP32 3.x, including I2C, hardware timers, LEDC/PWM, USB CDC, ESP-NOW callbacks, and Wi-Fi station MAC retrieval. It also adds CI coverage for both framework generations.
Motivation
When running the original firmware on Arduino-ESP32 3.x, several compatibility problems were observed:
WiFi.macAddress()could return an all-zero address during startup, causing the controller to save an invalid ESP-NOW peer address.Changes
Arduino-ESP32 compatibility
ToF and I2C
0x29to0x2A.ESP-NOW
esp_mac.hsupport for Arduino-ESP32 3.x.esp_read_mac(..., ESP_MAC_WIFI_STA).WiFi.macAddress()path for Arduino-ESP32 2.x.CI and repository cleanup
mainormaster.excludekey in the clang-format workflow.100755to100644.Backward Compatibility
The existing Arduino-ESP32 2.x environment and implementation paths remain available. Version-specific behavior is isolated through conditional compilation.
This PR does not intentionally change:
Validation
git diff --checkpasses.Notes
The configured I2C timeout is a maximum wait time, not an unconditional delay. Successful transfers return as soon as the underlying transaction completes.