Release 0.2.23 - #377
Merged
Merged
Release 0.2.23#377
Conversation
Build the library as a single translation unit (cherry picked from commit 935b9e8)
CI: check the single translation unit sources (cherry picked from commit a528502)
Add support for ESP32P4: Capture LCD reset mode and update Power class (cherry picked from commit 24dad4f)
Mic: never write past the record() buffer; reject empty requests (cherry picked from commit 3662def)
Mic: let record() from the release callback wait briefly for the request lock (cherry picked from commit 258ab46)
Speaker: serialize request publish/notify with end() under a request lock (cherry picked from commit 9e3f914)
Fix unused-function/variable warnings on non-P4 targets (cherry picked from commit 5e9bf6f)
Power: Core2 v1.1 suspend the DCDC under-voltage power-off while disabling the external output (cherry picked from commit 784e58a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audio
record()never writes past the caller's buffer. The capture task used to emit a whole conversion step at a time, so lengths that were not a multiple of the step overran by a few bytes;record()with a length of 0 or a null pointer now returnsfalseinstead of reporting success. Queued recordings stay continuous whatever their length. (Mic: never write past the record() buffer; reject empty requests #370)record()called from the buffer release callback no longer fails while the publisher still holds the request lock; it waits a few ticks instead, so the "two buffers re-queued from the callback" pattern works. (Mic: let record() from the release callback wait briefly for the request lock #372)play*()/stop()from an ordinary task andend()on another task are serialized under a request lock, closing a window in which the playback task handle could be used afterend()had deleted the task. (Speaker: serialize request publish/notify with end() under a request lock #373)Board fixes
setExtOutput(false)on USB power without a battery used to switch the PMIC off (DCDC under-voltage power-off, latched until the power key). The power-off is suspended for the transition, which turns it into an ESP32 brownout reset; the board reboots with the output enabled again. With a battery, or with 5 V on the bus, nothing changes. (Power: Core2 v1.1 suspend the DCDC under-voltage power-off while disabling the external output #375)Internal
.cppfiles became.inlfiles included fromM5Unified.cpp. Build times drop noticeably, and nothing changes for sketches or for builds through the Arduino / PlatformIO / ESP-IDF metadata. A custom build that globs*.cppundersrcshould listM5Unified.cpponly. (Build the library as a single translation unit #365)