Skip to content

Commit 5d8655d

Browse files
committed
Take NFCB off the board axis, leaving NFCA and UHF on it
1 parent 2819fd0 commit 5d8655d

4 files changed

Lines changed: 56 additions & 4 deletions

File tree

.github/workflows/arduino-esp-v2-build-check.yml

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,14 @@ jobs:
5757
platform-url:
5858
- https://espressif.github.io/arduino-esp32/package_esp32_index.json
5959

60+
# Cross design (skill m5-build-ci-matrix §3): the board axis is carried by one
61+
# representative per distinct code path. NFCA (WS1850S over I2C, addI2C) and UHF
62+
# (JRD4035 over UART, addUART) are different units on different transports, so both
63+
# stay on the board axis. NFCB is the same unit, bus and wiring helper as NFCA, so
64+
# one build on the representative board is enough to prove its stack compiles.
6065
nfctype:
6166
- NFCA
62-
- NFCB
67+
# - NFCB # via include (m5stack-core-esp32 only): same unit/bus/wiring as NFCA
6368

6469
sketch:
6570
- Detect
@@ -129,6 +134,15 @@ jobs:
129134
platform-version: 2.0.17
130135
board: m5stack-core-esp32
131136
build-properties: "-DUSING_UNIT_RFID2"
137+
# Detect (NFCB, USING_UNIT_RFID2, Core only) - moved off the board axis above
138+
- sketch: Detect
139+
nfctype: NFCB
140+
platform-url: https://espressif.github.io/arduino-esp32/package_esp32_index.json
141+
platform: esp32
142+
archi: esp32
143+
platform-version: 2.0.17
144+
board: m5stack-core-esp32
145+
build-properties: "-DUSING_UNIT_RFID2"
132146
# JapanIDCard (NFCB, USING_UNIT_RFID2, Core only)
133147
- sketch: JapanIDCard
134148
nfctype: NFCB

.github/workflows/arduino-esp-v3-build-check.yml

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,14 @@ jobs:
5757
platform-url:
5858
- https://espressif.github.io/arduino-esp32/package_esp32_index.json
5959

60+
# Cross design (skill m5-build-ci-matrix §3): the board axis is carried by one
61+
# representative per distinct code path. NFCA (WS1850S over I2C, addI2C) and UHF
62+
# (JRD4035 over UART, addUART) are different units on different transports, so both
63+
# stay on the board axis. NFCB is the same unit, bus and wiring helper as NFCA, so
64+
# one build on the representative board is enough to prove its stack compiles.
6065
nfctype:
6166
- NFCA
62-
- NFCB
67+
# - NFCB # via include (m5stack_core only): same unit/bus/wiring as NFCA
6368

6469
sketch:
6570
- Detect
@@ -149,6 +154,15 @@ jobs:
149154
platform-version: 3.3.6
150155
board: m5stack_dial
151156
build-properties: "-DUSING_M5DIAL_BUILTIN_WS1850S"
157+
# Detect (NFCB, USING_UNIT_RFID2, Core only) - moved off the board axis above
158+
- sketch: Detect
159+
nfctype: NFCB
160+
platform-url: https://espressif.github.io/arduino-esp32/package_esp32_index.json
161+
platform: esp32
162+
archi: esp32
163+
platform-version: 3.3.6
164+
board: m5stack_core
165+
build-properties: "-DUSING_UNIT_RFID2"
152166
# JapanIDCard (NFCB, USING_UNIT_RFID2, Core only)
153167
- sketch: JapanIDCard
154168
nfctype: NFCB

.github/workflows/arduino-m5-build-check.yml

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,14 @@ jobs:
5757
platform-url:
5858
- https://m5stack.oss-cn-shenzhen.aliyuncs.com/resource/arduino/package_m5stack_index.json
5959

60+
# Cross design (skill m5-build-ci-matrix §3): the board axis is carried by one
61+
# representative per distinct code path. NFCA (WS1850S over I2C, addI2C) and UHF
62+
# (JRD4035 over UART, addUART) are different units on different transports, so both
63+
# stay on the board axis. NFCB is the same unit, bus and wiring helper as NFCA, so
64+
# one build on the representative board is enough to prove its stack compiles.
6065
nfctype:
6166
- NFCA
62-
- NFCB
67+
# - NFCB # via include (m5stack_core only): same unit/bus/wiring as NFCA
6368

6469
sketch:
6570
- Detect
@@ -154,6 +159,15 @@ jobs:
154159
platform-version: 3.3.7
155160
board: m5stack_dial
156161
build-properties: "-DUSING_M5DIAL_BUILTIN_WS1850S"
162+
# Detect (NFCB, USING_UNIT_RFID2, Core only) - moved off the board axis above
163+
- sketch: Detect
164+
nfctype: NFCB
165+
platform-url: https://m5stack.oss-cn-shenzhen.aliyuncs.com/resource/arduino/package_m5stack_index.json
166+
platform: m5stack
167+
archi: esp32
168+
platform-version: 3.3.7
169+
board: m5stack_core
170+
build-properties: "-DUSING_UNIT_RFID2"
157171
# JapanIDCard (NFCB, USING_UNIT_RFID2, Core only)
158172
- sketch: JapanIDCard
159173
nfctype: NFCB

.github/workflows/platformio-build-check.yml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,14 @@ jobs:
5353
max-parallel: 20
5454

5555
matrix:
56+
# Cross design (skill m5-build-ci-matrix §3): the board axis is carried by one
57+
# representative per distinct code path. NFCA (WS1850S over I2C, addI2C) and UHF
58+
# (JRD4035 over UART, addUART) are different units on different transports, so both
59+
# stay on the board axis. NFCB is the same unit, bus and wiring helper as NFCA, so
60+
# one build on the representative board is enough to prove its stack compiles.
5661
example:
5762
- NFCA_Detect
58-
- NFCB_Detect
63+
# - NFCB_Detect # via include (Core only): same unit/bus/wiring as NFCA
5964
- UHF_Detect
6065

6166
# Build CI board axis = distinct compile config only (skill m5-build-ci-matrix).
@@ -89,6 +94,11 @@ jobs:
8994
- latest
9095

9196
include:
97+
# Detect (NFCB, Core only) - moved off the board axis above
98+
- example: NFCB_Detect
99+
board: Core
100+
framework: Arduino
101+
espressif32: latest
92102
# NFCA Specific sketches (Core only)
93103
- example: NFCA_Dump
94104
board: Core

0 commit comments

Comments
 (0)