Repository navigation
Add tests and CI; move data into data/ and images/ - #3
Merged
Merged
Conversation
- testthat suite (tests/testthat): data loading, every panel renders without warnings, regression checks for the bugs fixed in the previous commit, exported PNG/SVG/PDF (pixel size, SVG font fallback, no Type 3 fonts in the PDF), and vdiffr snapshots of panels B-F - figure_example.R: options(scifig.save = FALSE) builds the panels without writing files, options(scifig.out_dir = ...) writes elsewhere - DESCRIPTION lists the dependencies (not an R package) so CI and pak::local_install_deps() can install them - CI runs the tests on every push to main and every pull request Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Update the paths in figure_example.R and the tests, and describe the repository layout in the README. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2, which was merged before these two commits were pushed.
Tests and CI
tests/testthat/that checks:data_Cfiles.figure_example.Rhas two options for testing:options(scifig.save = FALSE)builds the panels without writing files, andoptions(scifig.out_dir = ...)writes the files to another folder.DESCRIPTIONlists the dependencies. This is not an R package; the file lets CI andpak::local_install_deps()install them..github/workflows/tests.yaml) runs the tests on every push tomainand every pull request.Layout
data/and the microscopy images toimages/. Git records these as renames, so file history is kept.Test plan
Rscript -e 'testthat::test_dir("tests/testthat")': 48 passed, 0 warningsRscript figure_example.Rwrites identical PNG and SVG after the file move🤖 Generated with Claude Code