Repository navigation
Conversation
A new Data tab in the app shows each data set (B, C, D1, D2, E, F) as a table, takes a CSV file to replace it, offers the example data as CSV, and switches back to the example data. Uploads are checked before they are used; a file with a problem is rejected with a message naming the column and row, and the previous data stay. Rows outside the fixed axis ranges are counted and reported under the figure. The data live in the session only. R/figure.R gets the shared pieces: - axis_limits(): the fixed axis ranges, now used by the panels' scales (same values, no snapshot changes) - check_figure_data(): column names and types from data_schemas(), missing values, positive values on log axes, at most two groups in C and three genes in E, horizontal error bars in E optional but paired - count_outside_axes() The panel cache key now includes the panel's data sets. DT is added to Suggests for the table. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Closing without merging: the dashboard won't accept user-uploaded data, for security reasons. The branch stays for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Data tab to the dashboard (#5): replace the data of panels B–F with your own CSV files.
The Data tab
DT).Column trachea_length, data row 5: 'n/a' is not a number.), and the previous data stay.Checks (
check_figure_data()): required columns and their types, missing values, positive values on the log axes (D widths and shear stress, F's K), at most two groups in C (two colours), at most three genes in E (three point shapes). In E the horizontal error columns are optional, but if given they must come in pairs.Changes in
R/figure.Raxis_limits()holds the fixed axis ranges. The panel scales now read them from there; the values are the same, and the snapshots are unchanged.check_figure_data()andcount_outside_axes()are new.Tested
testServer()a valid upload, an invalid upload that keeps the old data, the out-of-range note, the example CSV round trip, and resetting to the example data.shiny::runApp("app")and in a Shinylive export (headless Chromium, real file uploads): the invalid file is rejected with its message, the valid one replaces panel C, and the note reports the rows above the axis.DTis added toSuggests. In the Shinylive export it also bundlesrmarkdown/knitr; the export grows from 115 to 119 MB.🤖 Generated with Claude Code