Repository navigation
Conversation
snawaz
added this pull request to stack #264
October 21, 2026 20:39
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
snawaz
marked this pull request as ready for review
October 21, 2026 20:40
Add the direct-cluster path for committing and applying a finalized StateBuffer payload. Validate the buffer PDA, authority, commit identity, finalized length, and payload hash before reusing the CommitFinalize state transition for full-data and diff payloads. Store the canonical StateBuffer bump and align its payload for zero-copy diff decoding. Add PrepareCommitFinalize and a client helper so delegated accounts can grow across multiple runtime-limited realloc steps in the same transaction before finalization. Cover large chunked payloads, aligned diffs, and invalid finalized hashes with SBF tests.
Avoid reaching into the already-reviewed fraud-proof processor for shared hashing. Each instruction now computes the same domain-separated payload hash locally, while only the commit/finalize transition shared by this stack remains under processor/internal.
snawaz
force-pushed
the
snawaz/commit-finalize-from-buffer
branch
from
October 21, 2026 20:50
5f19fc0 to
5771b62
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the primary
CommitFinalizeFromBufferinstruction for Direct clusters. It validates and applies finalizedStateBufferpayloads, with preparation instructions for account growth beyond one realloc step. Legacy finalization remains unchanged.Closes #258