refactor(to-sqlite): migrate to pkg/csvops library

Completes the pkg/csvops migration — all 7 CSV operations now live as typed
functions with Progress callbacks and context cancellation.

ToSQLite exposes IfExistsAction as a typed enum (Replace/Skip/Append/Fail)
and returns Skipped in the result instead of erroring. Identifier safety
(QuoteIdent) and SanitizeTableName move to the library and get direct unit
tests, including the adversarial-table-name regression that was fixed in
v0.3.0.

Author: maherelgamil

cmd/to-sqlite.go

@@ -1,18 +1,13 @@
 package cmd
 
 import (
-	"database/sql"
-	"encoding/csv"
+	"context"
 	"fmt"
-	"io"
-	"os"
 	"path/filepath"
-	"regexp"
-	"strings"
 
+	"github.com/maherelgamil/csvops/pkg/csvops"
 	"github.com/schollz/progressbar/v3"
 	"github.com/spf13/cobra"
-	_ "modernc.org/sqlite"
 )
 
 var (
@@ -23,14 +18,6 @@ var (
 	csvToSqliteIfExists  string
 )
 
-var identSanitizer = regexp.MustCompile(`[^a-zA-Z0-9_]`)
-
-// quoteIdent safely quotes a SQLite identifier by wrapping in double quotes
-// and escaping embedded quotes.
-func quoteIdent(name string) string {
-	return `"` + strings.ReplaceAll(name, `"`, `""`) + `"`
-}
-
 var toSqliteCmd = &cobra.Command{
 	Use:   "to-sqlite",
 	Short: "Convert a CSV file into a SQLite database",
@@ -40,141 +27,34 @@ var toSqliteCmd = &cobra.Command{
 			return err
 		}
 
-		switch csvToSqliteIfExists {
-		case "replace", "skip", "append", "fail":
-		default:
-			return fmt.Errorf("--if-exists must be one of: replace, skip, append, fail")
-		}
-
-		if csvToSqliteTable == "" {
-			base := filepath.Base(csvToSqliteInput)
-			name := strings.TrimSuffix(base, filepath.Ext(base))
-			csvToSqliteTable = identSanitizer.ReplaceAllString(name, "_")
-		}
-
-		file, err := os.Open(csvToSqliteInput)
-		if err != nil {
-			return fmt.Errorf("failed to open input file: %w", err)
-		}
-		defer file.Close()
-
-		reader := csv.NewReader(file)
-		reader.Comma = delim
-
-		headers, err := reader.Read()
-		if err != nil {
-			return fmt.Errorf("failed to read CSV header: %w", err)
-		}
-
-		totalRows, err := countDataRows(csvToSqliteInput, delim)
-		if err != nil {
-			return err
-		}
-
-		dbPath, _ := filepath.Abs(csvToSqliteOutput)
-		db, err := sql.Open("sqlite", dbPath)
-		if err != nil {
-			return fmt.Errorf("failed to open sqlite db: %w", err)
-		}
-		defer db.Close()
-
-		tableIdent := quoteIdent(csvToSqliteTable)
-
-		exists, err := tableExists(db, csvToSqliteTable)
-		if err != nil {
-			return fmt.Errorf("failed to check if table exists: %w", err)
-		}
-
-		if exists {
-			switch csvToSqliteIfExists {
-			case "fail":
-				return fmt.Errorf("table %q already exists (use --if-exists replace|skip|append)", csvToSqliteTable)
-			case "skip":
-				fmt.Printf("⚠️  Table %q already exists, skipping.\n", csvToSqliteTable)
-				return nil
-			case "replace":
-				if _, err := db.Exec("DROP TABLE " + tableIdent); err != nil {
-					return fmt.Errorf("failed to drop existing table: %w", err)
+		var bar *progressbar.ProgressBar
+		res, err := csvops.ToSQLite(context.Background(), csvops.ToSQLiteOptions{
+			Input:     csvToSqliteInput,
+			DBPath:    csvToSqliteOutput,
+			Table:     csvToSqliteTable,
+			Delimiter: delim,
+			IfExists:  csvops.IfExistsAction(csvToSqliteIfExists),
+			Progress: func(done, total int64) {
+				if bar == nil {
+					bar = progressbar.Default(total, "Converting")
 				}
-				exists = false
-			case "append":
-				// keep existing table; rows will be inserted below
-			}
-		}
-
-		if !exists {
-			cols := make([]string, len(headers))
-			for i, h := range headers {
-				cols[i] = quoteIdent(h) + " TEXT"
-			}
-			createStmt := fmt.Sprintf("CREATE TABLE %s (%s)", tableIdent, strings.Join(cols, ", "))
-			if _, err := db.Exec(createStmt); err != nil {
-				return fmt.Errorf("failed to create table: %w", err)
-			}
-		}
-
-		placeholders := strings.TrimRight(strings.Repeat("?,", len(headers)), ",")
-		insertStmt := fmt.Sprintf("INSERT INTO %s VALUES (%s)", tableIdent, placeholders)
-
-		tx, err := db.Begin()
-		if err != nil {
-			return fmt.Errorf("failed to begin transaction: %w", err)
-		}
-		stmt, err := tx.Prepare(insertStmt)
+				_ = bar.Set64(done)
+			},
+		})
 		if err != nil {
-			_ = tx.Rollback()
-			return fmt.Errorf("failed to prepare insert statement: %w", err)
-		}
-		defer stmt.Close()
-
-		bar := progressbar.Default(totalRows, "Converting")
-		rowCount := 0
-		for {
-			record, err := reader.Read()
-			if err == io.EOF {
-				break
-			}
-			if err != nil {
-				_ = tx.Rollback()
-				return fmt.Errorf("failed to read row: %w", err)
-			}
-			vals := make([]interface{}, len(record))
-			for i := range record {
-				vals[i] = record[i]
-			}
-			if _, err := stmt.Exec(vals...); err != nil {
-				_ = tx.Rollback()
-				return fmt.Errorf("failed to insert row: %w", err)
-			}
-			_ = bar.Add(1)
-			rowCount++
+			return err
 		}
 
-		if err := tx.Commit(); err != nil {
-			return fmt.Errorf("failed to commit transaction: %w", err)
+		if res.Skipped {
+			fmt.Printf("⚠️  Table %q already exists, skipped.\n", res.Table)
+			return nil
 		}
-
-		fmt.Printf("\n✅ Imported %d rows into %s\n", rowCount, dbPath)
+		dbPath, _ := filepath.Abs(csvToSqliteOutput)
+		fmt.Printf("\n✅ Imported %d rows into %s\n", res.RowsImported, dbPath)
 		return nil
 	},
 }
 
-func tableExists(db *sql.DB, name string) (bool, error) {
-	row := db.QueryRow(
-		"SELECT 1 FROM sqlite_master WHERE type='table' AND name=?",
-		name,
-	)
-	var one int
-	err := row.Scan(&one)
-	if err == sql.ErrNoRows {
-		return false, nil
-	}
-	if err != nil {
-		return false, err
-	}
-	return true, nil
-}
-
 func init() {
 	rootCmd.AddCommand(toSqliteCmd)