Release MakePay 1.7.4 Bitcoin address compatibility - #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Incident context
The BTCPay plugin already reserves and forwards each store wallet address without converting its Bitcoin address type. The checkout failure was caused downstream by MakePay shared validation rejecting valid Taproot
bc1paddresses before provider/session creation; that service fix is tracked separately in CHASH-HOSTING/makeswap#994. This coordinated plugin release makes the pass-through behavior explicit and regression-tested.Production evidence also confirms valid
bc1qlinks reached SwapKit successfully, so this is specifically Taproot compatibility—not a general Bech32 or SwapKit outage.Verification
git diff --check