feat(hub): drop offline-mode (HF_HUB_OFFLINE) support - #75
Open
Mokuroh54 wants to merge 2 commits into
Open
Conversation
Running without the Hub is no longer a supported posture. Port of b4d752a from the pre-rollback lineage onto main: - Remove the --offline launcher flag; makermodslab-station is now just --lan. The station service file describes the LAN posture and no longer references an offline posture (or the nonexistent INSTALL.md). - Remove hf_hub_offline() and all nine refuse-when-offline guards (datasets, models, jobs, server training preflight), plus the offline field on /jobs/runners/hardware. - Frontend: remove the offline hard-blocks on Start, the CloudNotice offline branches, ManageCachesDialog's offline banner (and its now-pointless hardware fetch), and the '400 offline' doc comments. Deliberately kept: every transport-error degrade — hub status 'unknown', cached-listing resilience, 'offline / rate-limited' prose — those are about network failures, not the removed switch. Also kept: W&B's wandb_mode 'offline' option, which is unrelated. Port notes: the old lineage's useTrainingEnvironment/useTrainingConfig hooks don't exist on main (that plumbing is inline in TrainingConfigurator.tsx, ported there); jobs.py import adapted to main's shape; four non-offline dataset-availability tests relocated into test_datasets.py rather than deleted with test_training_preflight. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Mokuroh54
marked this pull request as ready for review
August 9, 2026 16:17
# Conflicts: # makermodslab/jobs.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running without the Hub is no longer a supported posture. This is a port of the orphaned
remove-hf-offlinework (original commit b4d752a, written on a pre-rollback lineage) onto current main.What's removed
--offlinelauncher flag —makermodslab-stationis now just--lan; the systemd service file describes the LAN posture (and no longer points at a nonexistent INSTALL.md — pre-existing dangling reference, removed).hf_hub_offline()and all nine refuse-when-offline guards (datasets ×5, models ×2, jobs, server training preflight), plus theofflinefield on/jobs/runners/hardware(all three return paths).What's deliberately kept
"unknown", cached-listing resilience, "offline / rate-limited" prose — those describe network failures, not the removed switch. A grep sweep confirms the only surviving "offline" mentions are this category, local-capability prose, and W&B's unrelatedwandb_modeselector.test_training_preflight.pywere relocated intotest_datasets.py, not dropped.Port adaptations (main drifted from the original lineage)
useTrainingEnvironment/useTrainingConfighooks don't exist on main; that plumbing is inline inTrainingConfigurator.tsxand was ported there (22-line diff vs the original's 35 — the difference is lineage-only code).jobs.pyimport block adapted to main's shape.Checks
Backend: ruff clean; scoped pytest 383 passed with zero new failures (7 pre-existing
test_models.pyisolation failures exist on main tip independently of this PR — real-cache leakage, tracked separately). Frontend:tsc -band lint identical to main baseline. Fullpre-commit run --all-files: green.package-lock.jsonandfrontend/dist/untouched.🤖 Generated with Claude Code