Skip to content

Commit cdc0146

Browse files
kaiaaiclaude
andcommitted
Fix runtime install aborting before it builds anything
build_workspace() sources /opt/ros/jazzy/setup.bash, which dereferences AMENT_TRACE_SETUP_FILES while the script runs under `set -euo pipefail`. Under `set -u` that is an unbound-variable error, so the installer exited before rosdep/colcon ever ran: /opt/ros/jazzy/setup.bash: line 8: AMENT_TRACE_SETUP_FILES: unbound variable Relax `set -u` around the source only. Verified in the jazzy-dev image: build_workspace now reaches rosdep + colcon. Bug found by Jayadev Rana by running the scaffold end to end; the original PR was verified with `bash -n`, which does not execute build_workspace. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent d938eff commit cdc0146

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

ubuntu/install_oomwoo_runtime_jazzy.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,11 @@ prepare_workspace() {
135135
}
136136

137137
build_workspace() {
138+
# ROS 2's setup.bash dereferences unset variables (AMENT_TRACE_SETUP_FILES),
139+
# which aborts the script under the `set -u` above. Relax it for the source.
140+
set +u
138141
. /opt/ros/jazzy/setup.bash
142+
set -u
139143
cd "$WORKSPACE"
140144
rosdep install --from-paths src --ignore-src -y
141145
colcon build --symlink-install

0 commit comments

Comments
 (0)