feat(validation): notify parked driver when every probe has answered

Once all CP-055 validation questions have recorded at least one line,
post one notification (parked only, once per process) asking for a
diagnostic export; tap opens Diagnostics. Stable gets a no-op hook.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: malys

CHANGELOG.md

@@ -6,6 +6,9 @@ All notable changes follow [Keep a Changelog](https://keepachangelog.com/en/1.1.
 
 ### Added
 
+- **"Validation results complete" notice (unstable, CP-055).** Once every validation question
+  has recorded at least one answer, a notification asks the driver to export the diagnostic to
+  USB; tapping it opens Diagnostics. Posted once per process, only with the car read as stopped.
 - **Battery stress while driving (CP-090).** When a trip spent 2 minutes or more pulling hard
   (above 60 % of its own peak) at a low charge (under 20 %) or below 0 °C outside, the trip-end
   line gains one clause, through the same voice, gate and advice history. The Battery page's

app/src/main/java/com/evsuite/chargepilot/TripRecordingService.kt

@@ -414,6 +414,8 @@ class TripRecordingService : Service() {
         // CP-087. The daily digest and the parked notification; both cost one comparison on
         // every other sample.
         batteryAdvisor.onSample(value)
+        // CP-055: once every validation question has answered, ask the parked driver to export.
+        EvidenceCaptureHook.onSample(this, ::inAppLanguage, value)
         if (automaticDetectionEnabled) {
             updateAutomaticMonitorAvailability(value)
             val previousState = detector.state

app/src/stable/java/com/evsuite/chargepilot/EvidenceCaptureHook.kt

@@ -2,6 +2,7 @@ package com.evsuite.chargepilot
 
 import android.app.Activity
 import android.content.Context
+import com.evsuite.hardware.telemetry.EnergySnapshot
 
 /**
  * Stable channel: no evidence capture, by construction.
@@ -20,6 +21,9 @@ object EvidenceCaptureHook {
     /** Does nothing. Stable arms no probe. */
     fun startProbes(context: Context) = Unit
 
+    /** Does nothing. Stable has no validation answer to announce. */
+    fun onSample(context: Context, text: () -> Context, value: EnergySnapshot) = Unit
+
     /** Does nothing. Stable has no probe artifact to write. */
     fun saveProbeArtifacts(context: Context) = Unit
 }

app/src/testUnstable/java/com/evsuite/chargepilot/ValidationProbeTest.kt

@@ -0,0 +1,15 @@
+package com.evsuite.chargepilot
+
+import org.junit.Assert.assertFalse
+import org.junit.Assert.assertTrue
+import org.junit.Test
+
+class ValidationProbeTest {
+    @Test
+    fun `ready only once every question has answered`() {
+        val all = ValidationQuestion.entries.toSet()
+        assertFalse(ValidationProbe.allAnswered(emptySet()))
+        assertFalse(ValidationProbe.allAnswered(all - ValidationQuestion.CHARGERS))
+        assertTrue(ValidationProbe.allAnswered(all))
+    }
+}

app/src/unstable/java/com/evsuite/chargepilot/EvidenceCaptureHook.kt

@@ -4,6 +4,7 @@ import android.app.Activity
 import android.content.Context
 import com.evsuite.hardware.FirmwareInfo
 import com.evsuite.hardware.probe.RuntimeInterfaceProbe
+import com.evsuite.hardware.telemetry.EnergySnapshot
 import java.io.File
 
 /** Unstable channel: the capture screen exists and is reachable from the dashboard. */
@@ -36,6 +37,10 @@ object EvidenceCaptureHook {
         RuntimeInterfaceProbe.connect(context)
     }
 
+    /** Each trip sample: tells the parked driver once that every validation answer is in. */
+    fun onSample(context: Context, text: () -> Context, value: EnergySnapshot) =
+        ValidationReadyNotice.onSample(context, text, value)
+
     /**
      * Writes every always-on probe artifact into the folder the diagnostic export bundles.
      *

app/src/unstable/java/com/evsuite/chargepilot/ValidationProbe.kt

@@ -159,6 +159,12 @@ object ValidationProbe {
         }
     }
 
+    /** Every question has at least one line: the bundle is worth exporting now. */
+    fun allAnswered(): Boolean = allAnswered(synchronized(rings) { rings.keys.toSet() })
+
+    internal fun allAnswered(answered: Set<ValidationQuestion>): Boolean =
+        answered.containsAll(ValidationQuestion.entries)
+
     /**
      * The car has a destination of its own and is guiding to it — the moment CP-051 asks about.
      *

app/src/unstable/java/com/evsuite/chargepilot/ValidationReadyNotice.kt

@@ -0,0 +1,81 @@
+package com.evsuite.chargepilot
+
+import android.Manifest
+import android.annotation.SuppressLint
+import android.app.NotificationChannel
+import android.app.NotificationManager
+import android.app.PendingIntent
+import android.content.Context
+import android.content.Intent
+import android.content.pm.PackageManager
+import android.os.Build
+import androidx.core.app.NotificationCompat
+import androidx.core.app.NotificationManagerCompat
+import androidx.core.content.ContextCompat
+import com.evsuite.hardware.AppLogger
+import com.evsuite.hardware.telemetry.EnergySnapshot
+
+/**
+ * Tells the driver once that every validation question has an answer, so the bundle is worth
+ * exporting now rather than after another drive spent guessing.
+ *
+ * Parked only, with the same gate as the battery advice: the questions mostly answer
+ * themselves on the road, and a notice that pops up at speed is the overlay the suite forbids.
+ * Once per process — the rings are in memory, so a restart starts the count again anyway.
+ */
+internal object ValidationReadyNotice {
+
+    @Volatile
+    private var posted = false
+
+    /** On the sampler thread, every sample; one flag and one set comparison until it fires. */
+    fun onSample(context: Context, text: () -> Context, value: EnergySnapshot) {
+        if (posted || !ValidationProbe.allAnswered()) return
+        val gate = ParkedDeletionPolicy.gate(value.speedKmh, value.timestampMs, System.currentTimeMillis())
+        if (gate != ParkedDeletionGate.PARKED) return
+        posted = true
+        AppLogger.i(TAG, "validation: every question answered, export suggested")
+        runCatching { post(context.applicationContext, text()) }
+            .onFailure { AppLogger.w(TAG, "validation notice failed: ${it.message}") }
+    }
+
+    // API 28 head unit: no permission gates a notification. On API 33+ without
+    // POST_NOTIFICATIONS (not declared) nothing is posted; the log line above still says it.
+    @SuppressLint("MissingPermission", "NotificationPermission")
+    private fun post(context: Context, res: Context) {
+        val manager = NotificationManagerCompat.from(context)
+        if (!manager.areNotificationsEnabled()) return
+        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU &&
+            ContextCompat.checkSelfPermission(context, Manifest.permission.POST_NOTIFICATIONS) !=
+            PackageManager.PERMISSION_GRANTED
+        ) return
+        context.getSystemService(NotificationManager::class.java)?.createNotificationChannel(
+            NotificationChannel(
+                CHANNEL_ID,
+                res.getString(R.string.validation_ready_channel),
+                NotificationManager.IMPORTANCE_DEFAULT,
+            )
+        )
+        val tap = PendingIntent.getActivity(
+            context, 0,
+            Intent(context, DiagnosticsActivity::class.java).addFlags(Intent.FLAG_ACTIVITY_NEW_TASK),
+            PendingIntent.FLAG_UPDATE_CURRENT or PendingIntent.FLAG_IMMUTABLE,
+        )
+        val body = res.getString(R.string.validation_ready_text)
+        manager.notify(
+            NOTIFICATION_ID,
+            NotificationCompat.Builder(context, CHANNEL_ID)
+                .setSmallIcon(R.drawable.ic_launcher_monochrome)
+                .setContentTitle(res.getString(R.string.validation_ready_title))
+                .setContentText(body)
+                .setStyle(NotificationCompat.BigTextStyle().bigText(body))
+                .setContentIntent(tap)
+                .setAutoCancel(true)
+                .build(),
+        )
+    }
+
+    private const val TAG = "EVChargePilot"
+    private const val CHANNEL_ID = "validation_ready"
+    private const val NOTIFICATION_ID = 200
+}

app/src/unstable/res/values-fr/strings.xml

@@ -33,6 +33,9 @@
     <string name="validation_arm">Armer le trajet de validation</string>
     <string name="validation_disarm">Désarmer le trajet de validation</string>
     <string name="validation_on">Mode validation actif. Chaque question ouverte s’enregistre seule ; exportez vers l’USB au retour.</string>
+    <string name="validation_ready_channel">Trajet de validation</string>
+    <string name="validation_ready_title">Résultats de validation complets</string>
+    <string name="validation_ready_text">Toutes les questions des sondes ont enregistré leur réponse. Exportez le diagnostic vers l’USB maintenant pour ne pas perdre ce trajet.</string>
     <string name="validation_off">Mode validation inactif. Rien n’est enregistré tant qu’il n’est pas armé.</string>
     <string name="update_title">Version instable disponible</string>
     <string name="update_ready">%1$s a été téléchargé dans :\n%2$s\n\nEVChargePilot ne peut pas l’installer. Ouvrez-le depuis le gestionnaire de fichiers du head unit, véhicule à l’arrêt.</string>

app/src/unstable/res/values/strings.xml

@@ -33,6 +33,9 @@
     <string name="validation_arm">Arm validation drive</string>
     <string name="validation_disarm">Disarm validation drive</string>
     <string name="validation_on">Validation mode on. Every open question records itself; export to USB when you are back.</string>
+    <string name="validation_ready_channel">Validation drive</string>
+    <string name="validation_ready_title">Validation results complete</string>
+    <string name="validation_ready_text">Every probe question has recorded its answer. Export the diagnostic to USB now so this drive is not lost.</string>
     <string name="validation_off">Validation mode off. Nothing is recorded until it is armed.</string>
     <string name="update_title">Unstable build available</string>
     <string name="update_ready">%1$s has been downloaded to:\n%2$s\n\nEVChargePilot cannot install it. Open it from the head unit’s file manager when the car is parked.</string>