feat(chargepilot): CP-086 open windows in the review, the advice and the details

A Windows tile in the Details climate grid (widest opening, %). The
trip review adds a Windows finding when the window-open residual is
distinguishable and above the cabin's minimum share, with the distance
driven open above 60 km/h; the trip-end advice and the general advice
card count it. Breakdown, attribution, diagnostic report and trip
export carry the field. EVHardware to 9b0b15c.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: malys

CHANGELOG.md

@@ -6,6 +6,13 @@ All notable changes follow [Keep a Changelog](https://keepachangelog.com/en/1.1.
 
 ### Added
 
+- **Open windows, measured and counted (CP-086).** A Windows tile in the Details climate grid
+  shows the widest opening in percent. The trip review adds a Windows finding when the window-open
+  residual is distinguishable and above the cabin's minimum share: its kWh, its share, and the
+  distance driven open above 60 km/h. The trip-end advice in P and the general advice card count
+  it, and the energy breakdown, the trip attribution, the diagnostic report and the trip export
+  carry it.
+
 - **Charges — a list of every charge, and what the watched ones measured (CP-082).** The battery
   page gains a *Charge history* button. The screen lists every charge newest first — start and
   end, charge before and after, duration, mean points per hour, outside temperature range and,

EVHardware

@@ -247,6 +247,9 @@ class ArrivalForecastActivity : PrimaryNavigationActivity() {
         )
         bind(binding.rangeValue, R.string.label_range, readings.range, PATTERN_DISTANCE)
         renderClimate(readings.climate, value.firmware)
+        bindWith(binding.windowsValue, R.string.label_windows, Provenanced.measured(value.widestWindowPercent)) {
+            getString(R.string.windows_value, it)
+        }
         bind(binding.tripDistanceValue, R.string.label_distance, readings.tripDistance, PATTERN_DISTANCE)
         bind(binding.tripEnergyValue, R.string.label_energy_used, readings.tripEnergy, PATTERN_ENERGY)
         bind(binding.tripRegenValue, R.string.label_regenerated, readings.tripRegen, PATTERN_ENERGY)

app/src/main/java/com/evsuite/chargepilot/ArrivalForecastActivity.kt

@@ -34,6 +34,7 @@ internal object DiagnosticSnapshotFormatter {
             "climate.fan_level_max=${climate.fanLevelMax.value()}",
             "climate.driver_target_c=${climate.driverTargetCelsius.value()}",
             "climate.passenger_target_c=${climate.passengerTargetCelsius.value()}",
+            "windows.widest_percent=${snapshot.widestWindowPercent.value()}",
             "tire.front_left_kpa=${tires.frontLeftKpa.value()}",
             "tire.front_right_kpa=${tires.frontRightKpa.value()}",
             "tire.rear_left_kpa=${tires.rearLeftKpa.value()}",

app/src/main/java/com/evsuite/chargepilot/DiagnosticSnapshotFormatter.kt

@@ -83,6 +83,7 @@ sealed interface EcoTip {
     data class EcoMode(val current: DriveMode?) : EcoTip
     data class SnowMode(val outsideTempCelsius: Int) : EcoTip
     data class Cabin(val finding: EcoFinding.Cabin) : EcoTip
+    data class Windows(val finding: EcoFinding.Windows) : EcoTip
 }
 
 /** The end-of-trip advice. [band] null when the fit refused; the tips may still stand. */
@@ -104,9 +105,11 @@ data class HistoryAdvice(
     val motorwayBasis: SpeedWhatIfBasis?,
     val motorwayTrips: Int,
     val cabinMeanPercent: Double?,
+    val windowsMeanPercent: Double?,
 ) {
     val hasAdvice: Boolean
-        get() = heavierTrips > 0 || style != null || motorwaySaving != null || cabinMeanPercent != null
+        get() = heavierTrips > 0 || style != null || motorwaySaving != null ||
+            cabinMeanPercent != null || windowsMeanPercent != null
 }
 
 /**
@@ -146,6 +149,7 @@ object EcoTripAdvice {
                 cold <= SNOW_MAX_OUTSIDE_CELSIUS
             ) add(EcoTip.SnowMode(cold.roundToInt()))
             findings.filterIsInstance<EcoFinding.Cabin>().forEach { add(EcoTip.Cabin(it)) }
+            findings.filterIsInstance<EcoFinding.Windows>().forEach { add(EcoTip.Windows(it)) }
         }.take(MAX_TIPS)
         return TripAdvice(
             band = band,
@@ -195,6 +199,7 @@ object EcoTripAdvice {
         var style = DrivingStyle.NONE
         val motorway = ArrayList<EcoFinding.MotorwaySpeed>()
         val cabin = ArrayList<Double>()
+        val windows = ArrayList<Double>()
         for (trip in recent) {
             style += DrivingStyle.measure(trip.samples.orEmpty())
             val ready = reviews[trip.summary.startedAtMs] as? EcoTripReview.Ready ?: continue
@@ -208,6 +213,7 @@ object EcoTripAdvice {
                 when (finding) {
                     is EcoFinding.MotorwaySpeed -> motorway += finding
                     is EcoFinding.Cabin -> cabin += finding.sharePercent
+                    is EcoFinding.Windows -> windows += finding.sharePercent
                     is EcoFinding.Steadiness -> Unit
                 }
             }
@@ -228,6 +234,7 @@ object EcoTripAdvice {
             motorwayTrips = sameBasis.size,
             // One cabin-heavy trip is weather; two are a habit worth naming.
             cabinMeanPercent = cabin.takeIf { it.size >= 2 }?.average(),
+            windowsMeanPercent = windows.takeIf { it.size >= 2 }?.average(),
         )
     }
 
@@ -308,6 +315,9 @@ class EcoAdviceText(context: Context) {
         advice.cabinMeanPercent?.let {
             lines += app.getString(R.string.eco_history_cabin, it.roundToInt())
         }
+        advice.windowsMeanPercent?.let {
+            lines += app.getString(R.string.eco_history_windows, it.roundToInt())
+        }
         return lines
     }
 
@@ -329,7 +339,7 @@ class EcoAdviceText(context: Context) {
         is EcoTip.EcoMode -> app.getString(R.string.eco_clause_eco_mode)
         is EcoTip.SlowerMotorway ->
             app.getString(R.string.eco_clause_motorway, tip.finding.referenceSpeedKmh)
-        is EcoTip.SnowMode, is EcoTip.Cabin -> null
+        is EcoTip.SnowMode, is EcoTip.Cabin, is EcoTip.Windows -> null
     }
 
     private fun sentence(tip: EcoTip): String = when (tip) {
@@ -351,5 +361,11 @@ class EcoAdviceText(context: Context) {
         )
         is EcoTip.Cabin ->
             app.getString(R.string.trip_eco_finding_cabin, tip.finding.kwh, tip.finding.sharePercent)
+        is EcoTip.Windows -> app.getString(
+            R.string.trip_eco_finding_windows,
+            tip.finding.kwh,
+            tip.finding.sharePercent,
+            tip.finding.openDistanceKm,
+        )
     }
 }

app/src/main/java/com/evsuite/chargepilot/EcoTripAdvice.kt

@@ -40,6 +40,17 @@ sealed interface EcoFinding {
         val sharePercent: Double,
     ) : EcoFinding
 
+    /**
+     * CP-086. The window-open intervals' fitted share of this trip, and how far the car went
+     * open above [EcoTripReviewer.WINDOWS_SPEED_KMH], where the drag is what an open window costs.
+     */
+    data class Windows(
+        val kwh: Double,
+        val uncertaintyKwh: Double,
+        val sharePercent: Double,
+        val openDistanceKm: Double,
+    ) : EcoFinding
+
     /** The share of moving time spent accelerating hard, from the track's speed channel. */
     data class Steadiness(val harshSharePercent: Double) : EcoFinding
 }
@@ -70,7 +81,7 @@ sealed interface EcoTripReview {
  * **Ranked by how strong the evidence is, not by a common cost.** A saving in kilowatt-hours, a
  * fitted cabin share and a percentage of a drive have no exchange rate, and inventing one to sort
  * them would invent the most important of the three. Order is therefore fixed and stated: the
- * measured saving first, the fitted share next, the style share last.
+ * measured saving first, the fitted shares next (cabin, then windows), the style share last.
  *
  * **What it refuses.** A model that has not trained, an attribution that could not reconcile, a
  * what-if with no motorway in the trip, a track that was never recorded — each drops its own
@@ -85,6 +96,13 @@ object EcoTripReviewer {
     /** Below this the cabin is inside the fit's own error and saying so would be noise. */
     const val MIN_CABIN_SHARE_PERCENT = 5.0
 
+    /** CP-086. Below this an open window is air, above it the drag starts to count. */
+    const val WINDOWS_SPEED_KMH = 60.0
+
+    /** Two samples further apart than this are a gap in the track, not a distance driven. */
+    private const val MAX_SAMPLE_GAP_MS = 120_000L
+    private const val MILLIS_PER_HOUR = 3_600_000.0
+
     fun review(
         trip: StoredTrip,
         socModel: SocConsumptionModel?,
@@ -102,6 +120,7 @@ object EcoTripReviewer {
         val findings = listOfNotNull(
             motorway(whatIf),
             cabin(attribution),
+            windows(trip, attribution),
             steadiness(monitor),
         ).take(MAX_FINDINGS)
         if (verdict.band.value == null && findings.isEmpty()) {
@@ -140,6 +159,11 @@ object EcoTripReviewer {
             " kwh=${format(finding.kwh)}" +
             " uncertainty_kwh=${format(finding.uncertaintyKwh)}" +
             " share_percent=${format(finding.sharePercent)}"
+        is EcoFinding.Windows -> "finding=WINDOWS" +
+            " kwh=${format(finding.kwh)}" +
+            " uncertainty_kwh=${format(finding.uncertaintyKwh)}" +
+            " share_percent=${format(finding.sharePercent)}" +
+            " open_km_above_60=${format(finding.openDistanceKm)}"
         is EcoFinding.Steadiness ->
             "finding=STEADINESS harsh_share_percent=${format(finding.harshSharePercent)}"
     }
@@ -191,6 +215,47 @@ object EcoTripReviewer {
         )
     }
 
+    /**
+     * CP-086. The same test as [cabin], on the window-open residual: distinguishable and above the
+     * same minimum share, or nothing.
+     */
+    private fun windows(trip: StoredTrip, attribution: EnergyAttributionResult?): EcoFinding.Windows? {
+        val ready = attribution as? EnergyAttributionResult.Ready ?: return null
+        val open = ready.attribution.residuals.filter {
+            it.context == ResidualContext.WINDOWS_OPEN &&
+                it.finding == ResidualFinding.DISTINGUISHABLE
+        }
+        if (open.isEmpty()) return null
+        val kwh = open.sumOf { it.estimate.valueKwh }
+        val total = ready.attribution.totalConsumedKwh.value ?: return null
+        if (total <= 0.0) return null
+        val share = kwh / total * 100.0
+        if (share < MIN_CABIN_SHARE_PERCENT) return null
+        return EcoFinding.Windows(
+            kwh = kwh,
+            uncertaintyKwh = open.sumOf { it.estimate.uncertaintyKwh },
+            sharePercent = share,
+            openDistanceKm = openFastDistanceKm(trip),
+        )
+    }
+
+    /** Trapezoid distance over the intervals open and above the speed at both ends. */
+    private fun openFastDistanceKm(trip: StoredTrip): Double =
+        trip.samples.orEmpty().zipWithNext().sumOf { (previous, current) ->
+            val durationMs = current.atMs - previous.atMs
+            val from = previous.speedKmh?.toDouble()
+            val to = current.speedKmh?.toDouble()
+            val open = (previous.widestWindowPercent ?: 0) > 0 &&
+                (current.widestWindowPercent ?: 0) > 0
+            if (!open || from == null || to == null || durationMs !in 1..MAX_SAMPLE_GAP_MS ||
+                from <= WINDOWS_SPEED_KMH || to <= WINDOWS_SPEED_KMH
+            ) {
+                0.0
+            } else {
+                (from + to) / 2.0 * durationMs / MILLIS_PER_HOUR
+            }
+        }
+
     /**
      * Whatever the share, once the track holds a minute of movement. A calm drive is a result
      * too: below the live advice threshold it used to drop out, and a calm drive with no fitted

app/src/main/java/com/evsuite/chargepilot/EcoTripReview.kt

@@ -299,6 +299,7 @@ class EnergyBreakdownActivity : AppCompatActivity() {
         ResidualContext.CLIMATE_ACTIVE -> R.string.energy_breakdown_residual_active
         ResidualContext.CLIMATE_INACTIVE -> R.string.energy_breakdown_residual_inactive
         ResidualContext.CLIMATE_UNKNOWN -> R.string.energy_breakdown_residual_unknown
+        ResidualContext.WINDOWS_OPEN -> R.string.energy_breakdown_residual_windows
     }
 
     private fun residualValue(value: ResidualAttribution): String = when (value.finding) {

app/src/main/java/com/evsuite/chargepilot/EnergyBreakdownActivity.kt

@@ -171,6 +171,8 @@ class TripExporter(
         addNullable("climateAcOn", sample.climateAcOn)
         sample.climateFanLevel?.let { addProperty("climateFanLevel", it) }
             ?: add("climateFanLevel", JsonNull.INSTANCE)
+        sample.widestWindowPercent?.let { addProperty("widestWindowPercent", it) }
+            ?: add("widestWindowPercent", JsonNull.INSTANCE)
     }
 
     private fun JsonObject.addFiniteOrNull(name: String, value: Double?) {

app/src/main/java/com/evsuite/chargepilot/TripExporter.kt

@@ -564,6 +564,12 @@ class TripHistoryActivity : PrimaryNavigationActivity() {
         )
         is EcoFinding.Cabin ->
             getString(R.string.trip_eco_finding_cabin, finding.kwh, finding.sharePercent)
+        is EcoFinding.Windows -> getString(
+            R.string.trip_eco_finding_windows,
+            finding.kwh,
+            finding.sharePercent,
+            finding.openDistanceKm,
+        )
         is EcoFinding.Steadiness -> getString(
             R.string.trip_eco_finding_steadiness,
             finding.harshSharePercent.roundToInt(),
@@ -623,6 +629,7 @@ class TripHistoryActivity : PrimaryNavigationActivity() {
                 ResidualContext.CLIMATE_ACTIVE -> R.string.trip_attribution_climate_active
                 ResidualContext.CLIMATE_INACTIVE -> R.string.trip_attribution_climate_inactive
                 ResidualContext.CLIMATE_UNKNOWN -> R.string.trip_attribution_climate_unknown
+                ResidualContext.WINDOWS_OPEN -> R.string.trip_attribution_windows_open
             },
         )
         return getString(

app/src/main/java/com/evsuite/chargepilot/TripHistoryActivity.kt

@@ -119,6 +119,12 @@
                         <TextView style="@style/Text.EV.ReadoutLabel" android:text="@string/label_climate_passenger_target" />
                         <TextView android:id="@+id/climatePassengerTargetValue" style="@style/Text.EV.ClimateValue" />
                     </LinearLayout>
+                    <!-- CP-086. The widest opening: an open window is a consumption factor, like
+                         the climate beside it. -->
+                    <LinearLayout style="@style/Widget.EV.ClimateReadout" android:layout_weight="1">
+                        <TextView style="@style/Text.EV.ReadoutLabel" android:text="@string/label_windows" />
+                        <TextView android:id="@+id/windowsValue" style="@style/Text.EV.ClimateValue" />
+                    </LinearLayout>
                 </LinearLayout>
 
                 <View