feat(catalog): one Call action taking a number or a contact

CALL_NUMBER now carries a CONTACT value, so a single catalogue entry accepts
either a typed number or a name from the phone book. Two entries for one
capability made the picker ask a question the user should not have to answer
before knowing what they wanted to dial.

CALL_CONTACT is deprecated and dropped from byGroup() rather than deleted:
enum entries are persisted by name, so removing it would deserialise to null
in every rule that already uses it — the crash class this catalogue has hit
before. It stays loadable and executable, and simply stops being offered.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: malys

AGENTS.md

@@ -3,6 +3,9 @@
 Shared vehicle-access library for the SAIC MG4 (AAOS 9, MT2712), consumed by MG4Control,
 MG4Tasker and MG4ABRPUploader via git submodule + Gradle subproject.
 
+MG4Hardware is the shared vehicle layer for **MG4Suite**. The workspace `AGENTS.md` and
+normative workspace `DESIGN.md` apply; this file defines library-specific invariants.
+
 Commit author: malys.training@gmail.com
 
 ## Why this exists
@@ -13,11 +16,10 @@ The apps are thin; the vehicle lives here.
 
 ## Non-negotiables
 
-- **The 0 km/h gate is here.** `VehicleWriteGate` refuses road-behaviour writes above
-  0 km/h and fails closed on unreadable speed, inside the low-level write primitives. Every
-  gated setter carries `@RequiresStandstill`; `RequiresStandstillTest`-style coverage keeps
-  the set honest. Comfort writes are not gated. Park rescues the unreadable-speed refusal
-  and nothing else — it must never override a speed that did read.
+- **The 0 km/h gate is here.** `VehicleWriteGate` permits a vehicle-setting write only when
+  speed is readable and exactly 0 km/h, inside the low-level write primitives. Every setter
+  carries `@RequiresStandstill`; coverage keeps the set honest. Unknown/negative speed
+  fails closed, and park state does not override that refusal.
 - **Per-firmware routing, never universal.** SWI68/69/131/132/133/165 differ; dispatch
   through `FirmwareInfo`. Any new vehicle call must branch per generation.
 - **Unreadable ≠ a value.** Getters return null / -1 when the layer is not ready or the

CHANGELOG.md

@@ -4,6 +4,16 @@ All notable changes to this project are documented here. Format follows
 [Keep a Changelog](https://keepachangelog.com/en/1.1.0/); versions follow
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [Unreleased]
+
+### Changed
+
+- **One "Call" action.** `CALL_NUMBER` now carries a `CONTACT` value, so the same entry takes
+  either a typed number or a name from the phone book. `CALL_CONTACT` is deprecated and no
+  longer offered by `ActionType.byGroup()`: it stays in the enum only so rules saved by a
+  release that exposed it still load and still call, since enum entries are persisted by name
+  and a removed one deserialises to null.
+
 ## [0.2.0] - 2026-08-02
 
 ### Added

lib/src/main/java/com/mg4/hardware/catalog/ActionType.kt

@@ -452,16 +452,22 @@ enum class ActionType(
     @SupportedOn(SWI68, SWI165)
     CALL_NUMBER(
         R.string.act_call, ActionGroup.SYSTEM,
-        ValueSpec(ValueKind.TEXT), "CALL_NUMBER"
+        ValueSpec(ValueKind.CONTACT), "CALL_NUMBER"
     ),
-    /** Selects from the PBAP-synchronised Android phone book, then calls the stored number. */
+    /**
+     * Kept only so rules saved by releases that exposed a separate contact action still load.
+     * New rules use [CALL_NUMBER], whose editor accepts either a number or a contact.
+     */
+    @Deprecated("Compatibility alias for saved rules; use CALL_NUMBER")
     @SupportedOn(SWI68, SWI165)
     CALL_CONTACT(
         R.string.act_call_contact, ActionGroup.SYSTEM,
         ValueSpec(ValueKind.CONTACT), "CALL_CONTACT"
     );
 
     companion object {
-        fun byGroup(): Map<ActionGroup, List<ActionType>> = entries.groupBy { it.group }
+        @Suppress("DEPRECATION")
+        fun byGroup(): Map<ActionGroup, List<ActionType>> =
+            entries.filterNot { it == CALL_CONTACT }.groupBy { it.group }
     }
 }

lib/src/main/res/values-de/strings.xml

@@ -136,7 +136,7 @@
     <string name="act_tune_radio">Radiosender einstellen</string>
     <string name="value_radio_hint">z. B. 103.5 oder AM 1080</string>
     <string name="act_navigate">Navigieren zu</string>
-    <string name="act_call">Nummer anrufen</string>
+    <string name="act_call">Anrufen</string>
     <string name="act_call_contact">Kontakt anrufen</string>
     <string name="cond_window_position">Fensteröffnung</string>
     <string name="cond_doors_locked">Türen verriegelt</string>

lib/src/main/res/values-es/strings.xml

@@ -136,7 +136,7 @@
     <string name="act_tune_radio">Sintonizar la radio</string>
     <string name="value_radio_hint">p. ej. 103.5 o AM 1080</string>
     <string name="act_navigate">Navegar hasta</string>
-    <string name="act_call">Llamar a un número</string>
+    <string name="act_call">Llamar</string>
     <string name="act_call_contact">Llamar a un contacto</string>
     <string name="cond_window_position">Apertura de ventanillas</string>
     <string name="cond_doors_locked">Puertas bloqueadas</string>

lib/src/main/res/values-fr/strings.xml

@@ -157,7 +157,7 @@
     <string name="act_navigate">Naviguer vers</string>
     <string name="act_webhook_get">Appeler un webhook (GET)</string>
     <string name="act_webhook_post">Appeler un webhook (POST)</string>
-    <string name="act_call">Appeler un numéro</string>
+    <string name="act_call">Appeler</string>
     <string name="act_call_contact">Appeler un contact</string>
     <string name="cond_window_position">Ouverture des vitres</string>
     <string name="cond_doors_locked">Portes verrouillées</string>

lib/src/main/res/values-it/strings.xml

@@ -136,7 +136,7 @@
     <string name="act_tune_radio">Sintonizza la radio</string>
     <string name="value_radio_hint">es. 103.5 o AM 1080</string>
     <string name="act_navigate">Naviga verso</string>
-    <string name="act_call">Chiama un numero</string>
+    <string name="act_call">Chiama</string>
     <string name="act_call_contact">Chiama un contatto</string>
     <string name="cond_window_position">Apertura finestrini</string>
     <string name="cond_doors_locked">Porte bloccate</string>

lib/src/main/res/values-pt/strings.xml

@@ -136,7 +136,7 @@
     <string name="act_tune_radio">Sintonizar o rádio</string>
     <string name="value_radio_hint">ex. 103.5 ou AM 1080</string>
     <string name="act_navigate">Navegar para</string>
-    <string name="act_call">Ligar para um número</string>
+    <string name="act_call">Ligar</string>
     <string name="act_call_contact">Ligar para um contacto</string>
     <string name="cond_window_position">Abertura dos vidros</string>
     <string name="cond_doors_locked">Portas trancadas</string>

lib/src/main/res/values/strings.xml

@@ -157,7 +157,7 @@
     <string name="act_navigate">Navigate to</string>
     <string name="act_webhook_get">Call webhook (GET)</string>
     <string name="act_webhook_post">Call webhook (POST)</string>
-    <string name="act_call">Call a number</string>
+    <string name="act_call">Call</string>
     <string name="act_call_contact">Call a contact</string>
     <string name="cond_window_position">Window opening</string>
     <string name="cond_doors_locked">Doors locked</string>

lib/src/test/java/com/mg4/hardware/catalog/CatalogConsistencyTest.kt

@@ -4,6 +4,7 @@ import com.mg4.hardware.catalog.ActionType
 import com.mg4.hardware.catalog.ConditionType
 import com.mg4.hardware.catalog.ValueKind
 import org.junit.Assert.assertFalse
+import org.junit.Assert.assertEquals
 import org.junit.Assert.assertNotNull
 import org.junit.Assert.assertTrue
 import org.junit.Test
@@ -15,6 +16,16 @@ import org.junit.Test
  */
 class CatalogConsistencyTest {
 
+    @Suppress("DEPRECATION")
+    @Test
+    fun `call is one public action accepting numbers or contacts`() {
+        val publicActions = ActionType.byGroup().values.flatten()
+
+        assertEquals(ValueKind.CONTACT, ActionType.CALL_NUMBER.spec.kind)
+        assertTrue(ActionType.CALL_NUMBER in publicActions)
+        assertFalse(ActionType.CALL_CONTACT in publicActions)
+    }
+
     @Test
     fun `toute action vehicule cible une action du pont`() {
         // bridgeAction=null est réservé aux actions locales (lancer une app, notifier).