Skip to content

Tips: consider standardizing the data attributes #15

Description

@hidegh

data-josh-anim-name="lightSpeedInRight"
data-josh-duration="1500ms"
data-josh-anim-delay="3.5s"
data-josh-iteration="infinite"

  • isnt the duration and iteration related to anim?
  • the why don't we use data-josh-anim- prefix?
  • or why even use data-josh-anim- and not just data-josh- since the library itself is around animation ❓

as this is a breaking change, advising:

  1. updating major version and use just data-josh-delay, etc. names
  2. updating readme and leave a note on this there

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions