Skip to content

Commit 2baa8ee

Browse files
generatedunixname1608173377072046meta-codesync[bot]
authored andcommitted
Fix test_align_single_reconstruction_only_aligns_3d_models for new align() signature
Summary: WARNING: Generated by Autopilot (alpha) — review carefully, verify the underlying claim before accepting. Agent: Jest-E2E Test Fixer Agent | Trajectory: https://www.internalfb.com/intern/devai/devmate/inspector/4bc91935-14fa-4b1f-b83d-001369c722d5/ | SC job: https://www.internalfb.com/intern/sandcastle/instance/31525200431482440/ --- ## The issue - D125282253 removed the `covariance` and `std_threshold` parameters, so `run_ba.align()` now takes 5 arguments. D125284298 landed afterward and still calls it with the old 7 arguments, so the test fails every run with `TypeError: align() takes 5 positional arguments but 7 were given`. ## The fix - Call `run_ba.align(path, 0, 1, True, 0.016)` in `test_align_single_reconstruction_only_aligns_3d_models`. Only this test changes; sibling failures in the same file are fixed separately (D125670887, D125671061, D125671079). Reviewed By: millenbop Differential Revision: D125671324 fbshipit-source-id: ac83c15ab47c023dbf0d109224083c670655801d
1 parent 92381be commit 2baa8ee

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎annotation_gui_gcp/tests/test_run_ba.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,7 @@ def test_fix_and_load_3d_annotations(self) -> None:
445445
def test_align_single_reconstruction_only_aligns_3d_models(self) -> None:
446446
self._write_dataset(two_reconstructions=False)
447447

448-
run_ba.align(str(self.path), 0, 1, True, False, 0.016, 0.3)
448+
run_ba.align(str(self.path), 0, 1, True, 0.016)
449449

450450
alignment = self._read_json("affine_alignment_0xmodel.ply.json")
451451
self.assertAlmostEqual(alignment["s"], 2.0, places=5)

0 commit comments

Comments
 (0)