Avoid unnecessary getattr/setattr

Author: marcelm

pyproject.toml

@@ -84,8 +84,6 @@ ignore = [
     "SIM905",  # Consider using a list literal instead of `str.split`
     "UP030",   # Use implicit references for positional format fields
     "UP006",   # Use `list` instead of `List` for type annotation
-    "B009",    # Do not call `getattr` with a constant attribute value. It is not any safer than normal property access.
-    "B010",    # Do not call `setattr` with a constant attribute value. It is not any safer than normal property access.
     "RUF059",  # Unpacked variable `matches` is never used
     "SIM102",  # Use a single `if` statement instead of nested `if` statements
     "FA100",   # Add `from __future__ import annotations` to simplify `typing.Optional`

tests/test_commandline.py

@@ -642,8 +642,8 @@ def test_max_n(run):
 def test_quiet_is_quiet():
     captured_standard_output = StringIO()
     captured_standard_error = StringIO()
-    setattr(captured_standard_output, "buffer", BytesIO())
-    setattr(captured_standard_error, "buffer", BytesIO())
+    captured_standard_output.buffer = BytesIO()
+    captured_standard_error.buffer = BytesIO()
     old_stdout = sys.stdout
     old_stderr = sys.stderr
     try:
@@ -655,8 +655,8 @@ def test_quiet_is_quiet():
         sys.stderr = old_stderr
     assert captured_standard_output.getvalue() == ""
     assert captured_standard_error.getvalue() == ""
-    assert getattr(captured_standard_output, "buffer").getvalue() == b""
-    assert getattr(captured_standard_output, "buffer").getvalue() == b""
+    assert captured_standard_output.buffer.getvalue() == b""
+    assert captured_standard_output.buffer.getvalue() == b""
 
 
 def test_x_brace_notation():