Repository navigation
Reject --rest-file and --wildcard-file with linked adapters up front - #897
Open
DylanCosto wants to merge 1 commit into
Open
DylanCosto wants to merge 1 commit into
DylanCosto wants to merge 1 commit into
Conversation
When --rest-file or --wildcard-file is combined with a linked adapter, the writer calls a method LinkedMatch does not implement. A matching read can therefore terminate processing after output files have already been opened. Assisted-by: Codex:GPT-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
--rest-fileor--wildcard-filewith a linked adapter currently crashes partway through processing (AttributeError: 'LinkedMatch' object has no attribute 'rest', #856), after the output files have already been opened.As you pointed out in #856, it isn't clear what the "rest" of a linked adapter should even be, and you mentioned possibly removing the option. So this doesn't try to define new output. It just turns the crash into a command-line error before any files are opened, the same way the guide already lists other options that don't work with linked adapters. For paired-end input only R1 adapters are checked, since both files describe R1. A linked adapter on R2 still works.
I added the limitation to the guide and a changelog entry, plus command-line tests for the rejected combinations and for the R2 case.