Repository navigation
feat: expose error type constants - #441
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumers have to hard-code strings to distinguish NitroSQLite failures, and importing the package root initializes the native runtime. This PR exports the existing error categories as a
NitroSQLiteExceptionTypeconstant object and derives the existing union type from its values. The newreact-native-nitro-sqlite/errorsentry point exports that object andNitroSQLiteErrorwithout loading React Native or Nitro.Existing category strings and type-only imports remain compatible. The error parser uses the same object, and source comments and the error-handling guide document the categories and new import path.
Regression coverage verifies that the errors entry point loads when native runtime imports throw and that both entry points share the same class and constants. The built CommonJS and ES module exports were also checked in an isolated package without native dependencies, including compatible type declarations.
Android CI also hit a Harness cache bug after all 137 integration tests passed. A dependency patch passes the Metro snapshot through a file instead of an oversized environment variable. A regression check exercises snapshots larger than 128 KiB and verifies unchanged caches, added files, save policy, and inline JSON compatibility.