Channel slots: full backupConfig grid, EEPROM sync, hide inactive (v1.5.2) - #22
Open
markminnoye wants to merge 2 commits into
Open
markminnoye wants to merge 2 commits into
markminnoye wants to merge 2 commits into
Conversation
Discovery now emits every relay/dimmer slot from backupConfig (24/8), marking empty descr+gr slots as active:false. Forced discovery merges missing slots into existing devices.json via sync_channels_from_wire, preserving operator name/room/active overrides (same pattern as pushbuttons). Co-authored-by: Mark Minnoye <mark.minnoye@gmail.com>
…backup - Skip inactive relay channels in UDP startup status sweep - sync_channels_from_wire follows backupConfig active on re-sync - expose_inactive_channels add-on option (default false); Web UI uses include_inactive - POST /api/v1/modules/refresh merges backupConfig channel slots into devices.json - Bump add-on to v1.5.2 Co-authored-by: Mark Minnoye <mark.minnoye@gmail.com>
|
Cursor Agent can help with this pull request. Just |
markminnoye
marked this pull request as ready for review
July 15, 2026 18:52
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the channel-slots follow-up (fixes 1–4) on top of the initial discovery change.
Fix 1 — Relay startup sweep
sweep_relay_statesskipsactive: falsechannels (faster startup, less UDP traffic)Fix 2 — EEPROM
activeon re-syncsync_channels_from_wirefollows wireactivefrombackupConfig(empty slot → inactive; named slot → active)name/roomstill preserved when setFix 3 — Hide inactive channels upstream
expose_inactive_channels(default false)?include_inactive=trueinclude_inactive=trueFix 4 — Refresh syncs channels
POST /api/v1/modules/refreshand per-module refresh fetchbackupConfigand merge intodevices.json(same pattern as pushbuttons viagetButtons)Also (initial commit on branch)
backupConfig; empty slots getactive: falsesync_channels_from_wireVersion: 1.5.2
Test plan
pytest tests/test_state_poll.py tests/test_device_config.py tests/test_discovery.py tests/test_gateway_api_modules.py tests/test_gateway_api_devices_patch.py tests/test_gateway_error_responses.py— 154 passed