Skip to content

fix: make bin/log compatible with Bash 3.2 on macOS (closes #1440) #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshust merged 1 commit into from
Jun 22, 2026
Merged

fix: make bin/log compatible with Bash 3.2 on macOS (closes #1440) #1442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 10 additions & 15 deletions compose/bin/log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,6 @@ Options:
-h, --help Display help message"
}

generate_logs_file_path() {
local container_log_path="$1"
shift # This shifts the positional parameters to the left, so $2 becomes $1, $3 becomes $2, etc.
local log_files=("$@")
local log_file_paths=()

for file in "${log_files[@]}"; do
log_file_paths+=("$container_log_path$file")
done

echo "${log_file_paths[@]}"
}

get_all_logs_file_path() {
local logs_location="$1"

Expand All @@ -38,9 +25,17 @@ get_all_logs_file_path() {
if [[ $1 == "-h" || $1 == "--help" ]]; then
display_help
elif [[ -z $1 ]]; then
mapfile -t all_logs_file_path < <(get_all_logs_file_path "$CONTAINER_LOG_PATH")
all_logs_file_path=()
while IFS= read -r line; do
all_logs_file_path+=("$line")
done < <(get_all_logs_file_path "$CONTAINER_LOG_PATH")

bin/docker-compose exec phpfpm tail -f "${all_logs_file_path[@]}"
else
mapfile -t logs_file_path < <(generate_logs_file_path "$CONTAINER_LOG_PATH" "$@")
logs_file_path=()
for file in "$@"; do
logs_file_path+=("${CONTAINER_LOG_PATH}${file}")
done

bin/docker-compose exec phpfpm tail -f "${logs_file_path[@]}"
fi