Omit -Wno-missing-braces from Makefiles and CMakeLists.txt

Author: martinmoene

contrib/lest_expect_abort/example/CMakeLists.txt

@@ -37,7 +37,7 @@ if( ${CMAKE_GENERATOR} MATCHES "Visual" )
 else()
     foreach( name ${TARGETS} )
         set( target "contrib-abort-${name}" )
-        target_compile_options( ${target} PUBLIC -std=c++11 -Wall -Wno-missing-braces )
+        target_compile_options( ${target} PUBLIC -std=c++11 -Wall )
     endforeach()
 endif()
 

contrib/lest_expect_abort/test/CMakeLists.txt

@@ -31,8 +31,8 @@ else()
         add_executable( ${target}       ${name}.cpp )
         add_executable( ${target}_cpp03 ${name}.cpp )
 
-        target_compile_options( ${target}       PUBLIC -std=c++11 -Wall -Wno-missing-braces -Dlest_FEATURE_AUTO_REGISTER=1 )
-        target_compile_options( ${target}_cpp03 PUBLIC -std=c++03 -Wall -Wno-missing-braces -Dlest_FEATURE_AUTO_REGISTER=1 )
+        target_compile_options( ${target}       PUBLIC -std=c++11 -Wall -Dlest_FEATURE_AUTO_REGISTER=1 )
+        target_compile_options( ${target}_cpp03 PUBLIC -std=c++03 -Wall -Dlest_FEATURE_AUTO_REGISTER=1 )
     endforeach()
 endif()
 

contrib/lest_expect_assert/example/CMakeLists.txt

@@ -34,7 +34,7 @@ if( ${CMAKE_GENERATOR} MATCHES "Visual" )
 else()
     foreach( name ${TARGETS} )
         set( target "contrib-assert-${name}" )
-        target_compile_options( ${target} PUBLIC -std=c++11 -Wall -Wno-missing-braces )
+        target_compile_options( ${target} PUBLIC -std=c++11 -Wall )
     endforeach()
 endif()
 

contrib/lest_expect_assert/test/CMakeLists.txt

@@ -29,8 +29,8 @@ else()
         add_executable( ${target}       ${name}.cpp )
         add_executable( ${target}_cpp03 ${name}.cpp )
 
-        target_compile_options( ${target}       PUBLIC -std=c++11 -Wall -Wno-missing-braces -Dlest_FEATURE_AUTO_REGISTER=1 )
-        target_compile_options( ${target}_cpp03 PUBLIC -std=c++03 -Wall -Wno-missing-braces -Dlest_FEATURE_AUTO_REGISTER=1 )
+        target_compile_options( ${target}       PUBLIC -std=c++11 -Wall -Dlest_FEATURE_AUTO_REGISTER=1 )
+        target_compile_options( ${target}_cpp03 PUBLIC -std=c++03 -Wall -Dlest_FEATURE_AUTO_REGISTER=1 )
     endforeach()
 endif()
 

example/BUCK

@@ -15,7 +15,6 @@ for x in examples:
       '-std=c++11',
       '-Wall',
       '-Wextra',
-      '-Wno-missing-braces',
       '-Dlest_FEATURE_AUTO_REGISTER=1',
     ],
     deps = [

example/Makefile

@@ -8,7 +8,7 @@
 # -Dlest_FEATURE_REGEX_SEARCH=0
 # -Dlest_FEATURE_TIME=1
 
-CXXFLAGS   := -Wall -Wextra -Wno-missing-braces -I../include
+CXXFLAGS   := -Wall -Wextra -I../include
 CXXFLAGS03 := $(CXXFLAGS) -std=c++03
 CXXFLAGS11 := $(CXXFLAGS) -std=c++11
 

example/Makefile.win.gcc

@@ -8,7 +8,7 @@
 # -Dlest_FEATURE_REGEX_SEARCH=0
 # -Dlest_FEATURE_TIME=1
 
-CXXFLAGS   := -Wall -Wextra -Wno-missing-braces -I../include
+CXXFLAGS   := -Wall -Wextra -I../include
 CXXFLAGS03 := $(CXXFLAGS) -std=c++03
 CXXFLAGS11 := $(CXXFLAGS) -std=c++11
 

test/CMakeLists.txt

@@ -38,7 +38,6 @@ if( NOT MSVC AND LEST_EXTRA_WARNINGS )
         -pedantic # : error: ISO C++11 requires at least one argument for the "..." in a variadic macro
         -pedantic-errors
         -Wundef
-        -Wno-missing-braces
         -Waggregate-return
         -Wcast-align
         -Wcast-qual
@@ -102,7 +101,7 @@ elseif( CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang|AppleClang" )
     set( HAS_STD_FLAGS  TRUE )
     set( HAS_CPP98_FLAG TRUE )
 
-    set( OPTIONS     -Wall -Wextra -Wconversion -Wsign-conversion -Wno-missing-braces -fno-elide-constructors )
+    set( OPTIONS     -Wall -Wextra -Wconversion -Wsign-conversion -fno-elide-constructors )
     set( DEFINITIONS ${LEST_CONFIG} )
 
     # GNU: available -std flags depends on version

test/Makefile

@@ -7,7 +7,7 @@
 # -Dlest_FEATURE_REGEX_SEARCH=0
 # -Dlest_FEATURE_TIME=1
 
-CXXFLAGS   := $(CXXFLAGS) -Wall -Wno-missing-braces -I../include
+CXXFLAGS   := $(CXXFLAGS) -Wall -I../include
 CXXFLAGS03 := $(CXXFLAGS) -std=c++03
 CXXFLAGS11 := $(CXXFLAGS) -std=c++11
 

test/Makefile.win.gcc

@@ -7,7 +7,8 @@
 # -Dlest_FEATURE_REGEX_SEARCH=0
 # -Dlest_FEATURE_TIME=1
 
-CXXFLAGS   := -Wall -Wextra -Weffc++ -Wno-missing-braces -I../include
+#CXXFLAGS   := -Wall -Wextra -Weffc++ -Wshadow -I../include
+CXXFLAGS   := -Wall -Wextra -Weffc++ -I../include
 CXXFLAGS03 := $(CXXFLAGS) -std=c++03
 CXXFLAGS11 := $(CXXFLAGS) -std=c++11