fix(core): keep the caret in place when backspace has nothing to delete - #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backspace with no digit before the caret now stores the caller's selection in history, matching the caret-at-zero guard in the same method. Both input controllers rendered the previous edit's caret through
currentStatein that branch, which sent the DOM caret to the end of the field when backspacing on a fixed plus. Regression tests cover the fixed-plus and national leading-parenthesis cases.Motivation
Closes #112.
Conformance impact
None.
Checklist
pnpm test,pnpm lint,pnpm formatpass locally