Skip to content

fix(msvc): silence C4702 unreachable warnings in value parser (#307) #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
soniafergusonship wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(msvc): silence C4702 unreachable warnings in value parser (#307) #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion include/toml++/impl/parser.inl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2772,7 +2772,8 @@ TOML_IMPL_NAMESPACE_START

// now things that can be identified from two or more characters
return_if_error({});
TOML_ASSERT_ASSUME(char_count >= 2u);
if (char_count < 2u)
set_error_and_return_default("could not determine value type"sv);

// do some 'fuzzy matching' where there's no ambiguity, since that allows the specific
// typed parse functions to take over and show better diagnostics if there's an issue
Expand Down Expand Up @@ -2833,6 +2834,10 @@ TOML_IMPL_NAMESPACE_START
// all correct value parses will come out of this list, so doing this as a switch is likely to
// be a better friend to the optimizer on the success path (failure path can be slow but that
// doesn't matter much).
#if TOML_MSVC
#pragma warning(push)
#pragma warning(disable : 4702) // unreachable code (false-positive from trait bitmask switch)
#endif
switch (unwrap_enum(traits))
{
// binary integers
Expand Down
Loading