chore: Fix lint and types issues + missing changes

Author: maxmilton

.oxfmtrc.jsonc

@@ -1,6 +1,6 @@
 {
   "$schema": "./node_modules/oxfmt/configuration_schema.json",
-  "ignorePatterns": ["CLAUDE.md", "SPEC.md"],
+  "ignorePatterns": ["CLAUDE.md", "SPEC.md", "static/*.html"],
   "sortImports": { "newlinesBetween": false },
   "sortPackageJson": true,
   "sortTailwindcss": true,

.oxlintrc.jsonc

@@ -76,7 +76,11 @@
     {
       "files": ["test/**/*.test.ts", "test/**/*.spec.ts"],
       "rules": {
+        "oxclippy/similar-names": "off",
         "unicorn/consistent-function-scoping": "off", // tests may define scoped helpers
+
+        // TODO: Remove when we can fix all the issues.
+        "typescript/no-unsafe-type-assertion": "off",
       },
     },
     {

README.md

@@ -33,7 +33,7 @@ What started as an experiment to play with the Chrome browser APIs and explore w
 
 ### Design goals
 
-<!-- dprint-ignore -->
+<!-- prettier-ignore -->
 | Issue | Why / How |
 | --- | --- |
 | Access | Still have access to common things like the bookmarks bar etc. |

eslint.config.js

@@ -1,8 +1,8 @@
 import js from "@eslint/js";
 import mm from "@maxmilton/eslint-config";
-import { defineConfig } from "eslint/config";
 import oxlint from "eslint-plugin-oxlint";
 import unicorn from "eslint-plugin-unicorn";
+import { defineConfig } from "eslint/config";
 import ts from "typescript-eslint";
 
 export default defineConfig(

globals.d.ts

@@ -3,7 +3,7 @@ import type { ONCLICK } from "stage1/fast";
 declare global {
   namespace NodeJS {
     interface ProcessEnv {
-      readonly CI?: string;
+      CI?: string;
     }
   }
 

src/newtab.ts

@@ -1,6 +1,5 @@
 // Theme loader code must run first
 import "./theme.ts";
-
 import { append, fragment } from "stage1/fast";
 import { BookmarkBar } from "./components/BookmarkBar.ts";
 import { Menu } from "./components/Menu.ts";

test/e2e/newtab.spec.ts

@@ -81,10 +81,10 @@ test("has no external or unexpected requests", async ({ page, extensionId }) =>
     const url = request.url();
     const type = request.resourceType();
     if (
-      (type === "document" && url === `chrome-extension://${extensionId}/newtab.html`)
-      || (type === "stylesheet" && url === `chrome-extension://${extensionId}/newtab.css`)
-      || (type === "script" && url === `chrome-extension://${extensionId}/newtab.js`)
-      || (type === "image" && url.startsWith(`chrome-extension://${extensionId}/_favicon?`))
+      (type === "document" && url === `chrome-extension://${extensionId}/newtab.html`) ||
+      (type === "stylesheet" && url === `chrome-extension://${extensionId}/newtab.css`) ||
+      (type === "script" && url === `chrome-extension://${extensionId}/newtab.js`) ||
+      (type === "image" && url.startsWith(`chrome-extension://${extensionId}/_favicon?`))
     ) {
       expected.push({ url, type });
     } else {

test/e2e/settings.spec.ts

@@ -58,10 +58,10 @@ test("makes no external or unexpected requests", async ({ page, extensionId }) =
     const url = request.url();
     const type = request.resourceType();
     if (
-      (type === "document" && url === `chrome-extension://${extensionId}/settings.html`)
-      || (type === "stylesheet" && url === `chrome-extension://${extensionId}/settings.css`)
-      || (type === "script" && url === `chrome-extension://${extensionId}/settings.js`)
-      || (type === "fetch" && url === `chrome-extension://${extensionId}/themes.json`)
+      (type === "document" && url === `chrome-extension://${extensionId}/settings.html`) ||
+      (type === "stylesheet" && url === `chrome-extension://${extensionId}/settings.css`) ||
+      (type === "script" && url === `chrome-extension://${extensionId}/settings.js`) ||
+      (type === "fetch" && url === `chrome-extension://${extensionId}/themes.json`)
     ) {
       expected.push({ url, type });
     } else {

test/unit/newtab.test.ts

@@ -1,7 +1,9 @@
 import { afterEach, describe, expect, spyOn, test } from "bun:test";
 import { compile, DECLARATION, lookup, walk } from "@maxmilton/test-utils/css";
 import { performanceSpy } from "@maxmilton/test-utils/spy";
-import { reset } from "../setup.ts";
+import type { UserStorageData } from "#types.ts";
+import { DEFAULT_SECTION_ORDER } from "#utils.ts";
+import { reset } from "./setup.ts";
 
 // Completely reset DOM and global state between tests
 afterEach(reset);
@@ -24,7 +26,7 @@ async function load(mockUserSettings?: UserStorageData) {
 }
 
 test("renders entire newtab app", async () => {
-  expect.assertions(5);
+  expect.assertions(7);
   await load();
   expect(document.body.getHTML().length).toBeGreaterThan(1000);
   expect(document.body.querySelector("#b")).toBeTruthy();

test/unit/setup.ts

@@ -1,5 +1,4 @@
 import "@maxmilton/test-utils/extend";
-
 import { setupDOM } from "@maxmilton/test-utils/dom";
 
 const noop = () => {};