Repository navigation
Close the skipped minors; list-metrics and guide for native 3-D files - #162
Merged
Merged
Conversation
…robustness) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXpnhJcJvaj5BxqfESMHNp
…16 body length follows GL-1 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXpnhJcJvaj5BxqfESMHNp
…in cm like before Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXpnhJcJvaj5BxqfESMHNp
…-NaN lengths Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXpnhJcJvaj5BxqfESMHNp
PreprocessedSession.z_speed holds the whole-session vertical speed; the Engine computes it once (geometry3d.vertical_speed) before windows are cut, slice_psess slices it, and Speed3D reads it, falling back to its own estimate for direct compute() calls. Unbinned IL-17 is unchanged; bin-edge values now match the whole-session estimate. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXpnhJcJvaj5BxqfESMHNp
…inned parallel native run Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXpnhJcJvaj5BxqfESMHNp
…essages; CLI formatter without private access Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXpnhJcJvaj5BxqfESMHNp
…elog and wording follow-ups Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXpnhJcJvaj5BxqfESMHNp
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXpnhJcJvaj5BxqfESMHNp
…ation screen no longer calls native files pixel-scaled Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXpnhJcJvaj5BxqfESMHNp
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXpnhJcJvaj5BxqfESMHNp
mbel-tech
changed the title
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012btUjvTQTf6i51Rpr3t8Hc
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXpnhJcJvaj5BxqfESMHNp
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXpnhJcJvaj5BxqfESMHNp
…differences The CI's Python 3.11 build differs from 3.12 by 1 ulp (about 1e-15 relative) in the savgol and nanmean results these two tests compared with ==. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXpnhJcJvaj5BxqfESMHNp
mbel-tech
marked this pull request as ready for review
October 11, 2026 18:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Closes the minor findings that the earlier deferred-minors work deliberately skipped, plus a few small parked ones, and finishes two follow-ups. Plan:
docs/superpowers/plans/2026-10-11-skipped-minors.md.Exported numbers that change (all listed in
CHANGELOG.md### Fixed):mean_nnd_3d_blfollows GL-1's body-length rule (identical for positive or NaN lengths; zero, negative and +inf lengths now behave as in GL-1).Robustness / wording (no number changes):
HEADER_TOO_LONGon an over-long header; duplicate-column scan warnings and an Anipose refusal; CLI log rewrite as alogging.Formatterwrapper; clearerNATIVE_3D_MIXEDtext.Added after the first draft:
t2d list-metricsnow lists what a native 3-D project rules out (IL-3, IL-9, IL-10, IL-14, IL-15 until the water column is given, every group metric), built fromavailability.unavailable_reasonso the wording matches the Metrics screen.origin/main(SP5/SP6). Conflicts were in the metrics code, where main'svertical_cm(water-column-bounded z) replaces myz_cmhelper, and in GL-16 (main'sfrac_frames_used_3dkept, GL-1 body-length rule applied).Not included, on purpose: the Anipose real-sample contract case (fixture host unreachable) and rewriting commit trailers (needs a force-push of merged history).
Test plan
4555 passed, 213 skipped(QT_QPA_PLATFORM=offscreen pytest -q -W error::RuntimeWarning);ruff check .and CI-configmypyclean;scripts/check_wiki.pyclean.Checklist
ruff check .passesdocs/METRICS_SPEC.md, user guide, PDF, screenshots)CHANGELOG.mdentries under[Unreleased]Known leftover (wording only): when a native file is added to a legacy manifest whose existing entries have no recorded reader, those entries are described as "not a native 3-D file" instead of "pixel-tracked".
🤖 Generated with Claude Code
https://claude.ai/code/session_01QXpnhJcJvaj5BxqfESMHNp