chore: bump Rust dependency versions, fix flaky tests, clean up clippy lints

Renovate-style patch/minor bumps across huginn/odin/shared (tokio, serde,
regex, handlebars, sysinfo, thiserror, etc.). Removes valheim-postcopy.sh,
whose Dockerfile invocation was already commented out.

Also fixes 3 pre-existing flaky discord notification tests: they didn't
set $NAME or use #[serial], so they'd race with other tests mutating the
NAME env var and panic when falling back to a nonexistent config file.

Applies cargo clippy --fix and cargo fmt for pre-existing lint/format
issues (unrelated to the dependency bump, but blocking the pre-commit
hook).

Co-Authored-By: Claude <noreply@anthropic.com>

Author: mbround18

Cargo.lock

@@ -15,14 +15,14 @@ name = "huginn"
 path = "main.rs"
 
 [build-dependencies]
-cc = "1.2.64"
+cc = "1.3.0"
 
 [dependencies]
-log = "0.4.32"
-tokio = { version = "1.52.3", features = ["full"] }
+log = "0.4.33"
+tokio = { version = "1.53.1", features = ["full"] }
 warp = { version = "0.4.3", features = ["server"] }
-serde = { version = "1.0.228", features = ["derive"], default-features = false }
-serde_json = "1.0.150"
+serde = { version = "1.0.229", features = ["derive"], default-features = false }
+serde_json = "1.0.151"
 a2s = "0.6.1"
 
 [dependencies.odin]
@@ -43,4 +43,4 @@ features = [
 ]
 
 [dev-dependencies]
-regex = "1.12.4"
+regex = "1.13.1"

src/huginn/Cargo.toml

@@ -20,22 +20,22 @@ pub fn invoke() -> String {
   let content = [
     format!(
       "valheim_online{labels} {online}",
-      labels = &labels,
+      labels = labels,
       online = info.online as i32
     ),
     format!(
       "valheim_current_player_count{labels} {players}",
-      labels = &labels,
-      players = &info.players
+      labels = labels,
+      players = info.players
     ),
     format!(
       "valheim_max_player_count{labels} {players}",
-      labels = &labels,
-      players = &info.max_players
+      labels = labels,
+      players = info.max_players
     ),
     format!(
       "valheim_bepinex_installed{labels} {bepinex_installed}",
-      labels = &labels,
+      labels = labels,
       bepinex_installed = info.bepinex.enabled as i32
     ),
     // System metrics (no labels beyond server identity)

src/huginn/routes/metrics.rs

@@ -22,22 +22,22 @@ name = "odin"
 path = "lib.rs"
 
 [build-dependencies]
-cc = "1.2.64"
+cc = "1.3.0"
 
 [dependencies]
-handlebars = "6.4.1"
+handlebars = "6.4.3"
 dotenv = "0.15.0"
-log = "0.4.32"
-clap = { version = "4.6.1", features = ["derive", "env"] }
-which = "8.0.4"
-serde = { version = "1.0.228", features = ["derive"], default-features = false }
-sysinfo = { version = "0.39.3" }
-serde_json = "1.0.150"
+log = "0.4.33"
+clap = { version = "4.6.3", features = ["derive", "env"] }
+which = "8.0.5"
+serde = { version = "1.0.229", features = ["derive"], default-features = false }
+sysinfo = { version = "0.39.6" }
+serde_json = "1.0.151"
 daemonize = "0.5.0"
 tar = "0.4.46"
 flate2 = "1.1.9"
 inflections = "1.1.1"
-md5 = "0.8.0"
+md5 = "0.8.1"
 reqwest = { version = "0.13.4", default-features = false, features = [
   "blocking",
   "json",
@@ -49,13 +49,13 @@ fs_extra = "1.3.0"
 glob = "0.3.3"
 a2s = "0.6.1"
 serde_with = "3.21.0"
-regex = "1.12.4"
-tokio = { version = "1.52.3", features = ["full"] }
+regex = "1.13.1"
+tokio = { version = "1.53.1", features = ["full"] }
 notify = "8.2.0"
 json-patch = "4.2.0"
 cached = "2.0.2"
-anyhow = "1.0.102"
-thiserror = "2.0.18"
+anyhow = "1.0.104"
+thiserror = "2.0.19"
 tempfile = "3.27.0"
 walkdir = "2.5.0"
 sha2 = "0.11.0"
@@ -66,12 +66,12 @@ workspace = true
 
 [dev-dependencies]
 once_cell = "1.21.4"
-rand = "0.10.1"
+rand = "0.10.2"
 serial_test = "3.5.0"
 mockito = "1.7.2"
 lazy_static = "1.5.0"
 test-case = "3.3.1"
-mockall = "0.14.0"
+mockall = "0.15.0"
 
 
 [dev-dependencies.cargo-husky]

src/odin/Cargo.toml

@@ -11,7 +11,7 @@ pub fn invoke(input: String, output: String) {
   let tar_gz = match File::create(&output) {
     Ok(file) => file,
     Err(_) => {
-      error!("Failed to create backup file at {}", &output);
+      error!("Failed to create backup file at {}", output);
       exit(1)
     }
   };

src/odin/commands/backup.rs

@@ -26,12 +26,12 @@ pub fn invoke(dry_run: bool) {
     info!(
       target: "commands_start",
       "This command would have launched\n{} -nographics -batchmode -port {} -name {} -world {} -password {} -public {}",
-      &config.command,
-      &config.port,
-      &config.name,
-      &config.world,
-      &config.password,
-      &config.public,
+      config.command,
+      config.port,
+      config.name,
+      config.world,
+      config.password,
+      config.public,
     )
   }
 }

src/odin/commands/start.rs

@@ -10,7 +10,7 @@ impl error::Error for VariantNotFound {}
 
 impl Display for VariantNotFound {
   fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-    write!(f, "VariantNotFound: {}", &self.v)
+    write!(f, "VariantNotFound: {}", self.v)
   }
 }
 

src/odin/errors/mod.rs

@@ -81,33 +81,33 @@ impl TryInto<Vec<String>> for ValheimArguments {
     let mut args = Vec::new();
     // Sets the port of the server, (Can be set with ENV variable PORT)
     let port = fetch_var("PORT", &self.port);
-    debug!("Setting port to: {}", &port);
+    debug!("Setting port to: {}", port);
     args.push(String::from("-port"));
     args.push(port);
 
     // Sets the name of the server, (Can be set with ENV variable NAME)
     let name = fetch_var("NAME", &self.name);
-    debug!("Setting name to: {}", &name);
+    debug!("Setting name to: {}", name);
     args.push(String::from("-name"));
     // Arg processor needs the quotes around the name if it has spaces
     args.push(format!("'{}'", name));
 
     // Sets the world of the server, (Can be set with ENV variable WORLD)
     let world = fetch_var("WORLD", &self.world);
-    debug!("Setting world to: {}", &world);
+    debug!("Setting world to: {}", world);
     args.push(String::from("-world"));
     args.push(world);
 
     // Determines if the server is public or not
     let public = fetch_var("PUBLIC", &self.public);
-    debug!("Setting public to: {}", &public);
+    debug!("Setting public to: {}", public);
     args.push(String::from("-public"));
     args.push(public.clone());
 
     // Sets the save interval in seconds
     if let Some(save_interval) = &self.save_interval {
       let interval = save_interval.to_string();
-      debug!("Setting save interval to: {}", &interval);
+      debug!("Setting save interval to: {}", interval);
       args.push(String::from("-saveinterval"));
       args.push(interval);
     };
@@ -119,26 +119,23 @@ impl TryInto<Vec<String>> for ValheimArguments {
         .map(|key| key.trim())
         .filter(|key| !key.is_empty())
         .for_each(|key| {
-          debug!("Setting set_key to: {}", &key);
+          debug!("Setting set_key to: {}", key);
           args.push(String::from("-setkey"));
           args.push(key.to_string());
         });
     };
 
     // Add preset to the command
     if let Some(preset) = &self.preset {
-      debug!("Setting preset to: {}", &preset);
+      debug!("Setting preset to: {}", preset);
       args.push(String::from("-preset"));
       args.push(preset.to_string());
     };
 
     // Add modifiers to the command
     if let Some(modifiers) = &self.modifiers {
       modifiers.iter().for_each(|modifier| {
-        debug!(
-          "Setting modifier to: {} {}",
-          &modifier.name, &modifier.value
-        );
+        debug!("Setting modifier to: {} {}", modifier.name, modifier.value);
         args.push(String::from("-modifier"));
         args.push(modifier.name.to_string());
         args.push(modifier.value.to_string());

src/odin/files/config.rs

@@ -162,7 +162,7 @@ impl BepInExEnvironment {
   pub fn new() -> BepInExEnvironment {
     let game_dir = game_directory();
     let bepinex_dir = bepinex_directory();
-    let bepinex_preloader_dll = format!("{}/core/BepInEx.Preloader.dll", &bepinex_dir);
+    let bepinex_preloader_dll = format!("{}/core/BepInEx.Preloader.dll", bepinex_dir);
 
     // Detect BepInExPack_Valheim version from manifest.json if present and cross-check filesystem
     let mut doorstop_is_v4_plus =
@@ -173,15 +173,15 @@ impl BepInExEnvironment {
 
     debug!("Parsing Doorstop locations.");
     let doorstop_lib_default = if doorstop_is_v4_plus {
-      format!("{}/doorstop_libs/libdoorstop_x64.so", &game_dir)
+      format!("{}/doorstop_libs/libdoorstop_x64.so", game_dir)
     } else {
       String::from("libdoorstop_x64.so")
     };
     let doorstop_lib = environment::fetch_var(DOORSTOP_LIB_VAR, &doorstop_lib_default);
     let doorstop_libs = parse_path(
       DOORSTOP_LIBS_VAR,
-      format!("{}/doorstop_libs", &game_dir),
-      format!("{}/doorstop", &bepinex_dir),
+      format!("{}/doorstop_libs", game_dir),
+      format!("{}/doorstop", bepinex_dir),
     );
     let doorstop_target_assembly =
       environment::fetch_var(DOORSTOP_TARGET_ASSEMBLY_VAR, &bepinex_preloader_dll);
@@ -190,15 +190,15 @@ impl BepInExEnvironment {
     // Prefer BepInEx/core_lib, fallback to BepInEx/core; no more game_dir/unstripped_corlib
     let doorstop_corlib_override_path = parse_path(
       DOORSTOP_CORLIB_OVERRIDE_PATH_VAR,
-      format!("{}/core_lib", &bepinex_dir),
-      format!("{}/core", &bepinex_dir),
+      format!("{}/core_lib", bepinex_dir),
+      format!("{}/core", bepinex_dir),
     );
 
     debug!("Parsing LD locations.");
     let ld_preload = environment::fetch_var(constants::LD_PRELOAD_VAR, "").add(&doorstop_lib);
     let ld_library_path = environment::fetch_var(
       constants::LD_LIBRARY_PATH_VAR,
-      format!("./linux64:{}", &doorstop_libs).as_str(),
+      format!("./linux64:{}", doorstop_libs).as_str(),
     );
 
     debug!("Returning environment");
@@ -221,8 +221,8 @@ impl BepInExEnvironment {
     debug!("Checking for BepInEx specific files...");
     // Choose checks based on detected mode
     // For Doorstop v4+: verify native lib in doorstop_libs dir (Linux .so or macOS .dylib)
-    let lib_so = format!("{}/libdoorstop_x64.so", &self.doorstop_libs_dir);
-    let lib_dylib = format!("{}/libdoorstop_64.dylib", &self.doorstop_libs_dir);
+    let lib_so = format!("{}/libdoorstop_x64.so", self.doorstop_libs_dir);
+    let lib_dylib = format!("{}/libdoorstop_64.dylib", self.doorstop_libs_dir);
     let checks_v4 = [&self.doorstop_target_assembly];
     let checks_v3 = [&self.doorstop_lib, &self.doorstop_invoke_dll];
     let expected_state = true;
@@ -231,21 +231,21 @@ impl BepInExEnvironment {
       let dylib_exists = path_exists(&lib_dylib);
       let target_exists = path_exists(&self.doorstop_target_assembly);
       debug!("Doorstop v4+ checks:");
-      debug!(" - lib (so): {} => {}", &lib_so, so_exists);
-      debug!(" - lib (dylib): {} => {}", &lib_dylib, dylib_exists);
+      debug!(" - lib (so): {} => {}", lib_so, so_exists);
+      debug!(" - lib (dylib): {} => {}", lib_dylib, dylib_exists);
       debug!(
         " - target assembly: {} => {}",
-        &self.doorstop_target_assembly, target_exists
+        self.doorstop_target_assembly, target_exists
       );
       (so_exists || dylib_exists) && checks_v4.iter().all(|v| path_exists(v) == expected_state)
     } else {
       let lib_exists = path_exists(&self.doorstop_lib);
       let invoke_exists = path_exists(&self.doorstop_invoke_dll);
       debug!("Doorstop v3 checks:");
-      debug!(" - doorstop_lib: {} => {}", &self.doorstop_lib, lib_exists);
+      debug!(" - doorstop_lib: {} => {}", self.doorstop_lib, lib_exists);
       debug!(
         " - invoke dll: {} => {}",
-        &self.doorstop_invoke_dll, invoke_exists
+        self.doorstop_invoke_dll, invoke_exists
       );
       checks_v3.iter().all(|v| path_exists(v) == expected_state)
     };

src/odin/mods/bepinex.rs

@@ -16,12 +16,12 @@ impl TryFrom<PathBuf> for Manifest {
   type Error = Box<dyn std::error::Error>;
 
   fn try_from(value: PathBuf) -> Result<Self, Self::Error> {
-    debug!("Reading Manifest from {:?}", &value);
+    debug!("Reading Manifest from {:?}", value);
 
     if !value.exists() {
       return Err(Box::new(ManifestDeserializeError(format!(
         "Failed to find manifest at {:?}",
-        &value
+        value
       ))));
     }
 
@@ -32,7 +32,7 @@ impl TryFrom<PathBuf> for Manifest {
     if content.trim().is_empty() {
       return Err(Box::new(ManifestDeserializeError(format!(
         "Manifest file at {:?} is empty",
-        &value
+        value
       ))));
     }