Repository navigation
feat(car): show a slot green when the charger may divert - #5
Merged
Merged
Conversation
…en it does The plan only coloured the car column green where the model produced diverted energy, so a slot where the charger was free to take the sun but the surplus was too small to start it looked identical to a slot with no sun at all. Those are different situations and the difference is the one a user is trying to see when they check whether the feature is working. The prediction now records the opportunity separately from the energy - every gate satisfied: the car plugged in, PV present, room below the solar limit, the export not worth more and the home battery above its priority SoC. A green slot showing 0 now means "allowed, but nothing expected", which points at car_charging_solar_min_power rather than looking like a bug. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plan coloured the car column green only where the model produced diverted energy, so a slot where the charger was free to take the sun but the surplus was too small to start it looked identical to a slot with no sun at all.
The prediction now records the opportunity separately from the energy - car plugged in, PV present, room below the solar limit, export not worth more, home battery above its priority SoC. A green slot showing
0means "allowed, but nothing expected", which points atcar_charging_solar_min_powerrather than looking like a bug.New
car_solar_possibletest covers the min-power case and the unplugged case.🤖 Generated with Claude Code