Skip to content

[Bug]: Objective function that the NOTEARS algorithm with lasso regularisation  #239

Description

@RuikeZ

Contact Details

ruikezhang2013@gmail.com

Short description of the problem here.

Hi, I've noticed the Lasso regularisation is using w_vec.sum() in https://github.com/mckinsey/causalnex/blob/0.4.2/causalnex/structure/notears.py#L489
loss + 0.5 * rho * h_val * h_val + alpha * h_val + beta * w_vec.sum()
wondering if it makes more sense to use np.linalg.norm(w_est)?

CausalNex Version

0.4.2

Python Version

3.10

Relevant code snippet

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions