Skip to content

Commit d210c9c

Browse files
committed
test(ci): trace detached Windows status writes directly
1 parent ebff0ac commit d210c9c

3 files changed

Lines changed: 2 additions & 4 deletions

File tree

‎.github/workflows/cross-build-test.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -529,7 +529,6 @@ jobs:
529529
shell: bash
530530
run: |
531531
export MCPP_VENDORED_XLINGS="$XLINGS_BIN"
532-
export MCPP_TEST_NATIVE_RENAME=1 # CI-only diagnosis; remove before release
533532
"$MCPP_SELF" build --target x86_64-linux-musl
534533
# Scope the search to the TARGET's output tree — target/ also holds the
535534
# host build from the previous step, and both are named "mcpp*".

‎src/build/schedule/compiler_transaction.cpp‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,7 @@ bool replace_record(const fs::path& path,std::string_view bytes,std::string* dia
5252
// CI-only root-cause probe. Remove before merge: it intentionally
5353
// compares the standard library's rename of this exact source to
5454
// a distinct diagnostic name, without publishing the status.
55-
if(noReplaceCode==static_cast<int>(os::errc::invalid)
56-
&& std::getenv("MCPP_TEST_NATIVE_RENAME")!=nullptr) {
55+
if(noReplaceCode==static_cast<int>(os::errc::invalid)) {
5756
const auto sourceLocation=os::fs::locate(temporary);
5857
const auto targetLocation=os::fs::locate(path);
5958
const auto readable=os::fs::read(temporary);

‎src/build/schedule/detach_codegen.cppm‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ bool write_rc(const std::filesystem::path& slot, int rc,std::string* diagnostic=
319319
#if defined(_WIN32)
320320
// CI-only: early supervisor failures have no caller-owned diagnostic.
321321
// Report their status-publication failure without printing private paths.
322-
if(!written&&!diagnostic&&std::getenv("MCPP_TEST_NATIVE_RENAME")!=nullptr)
322+
if(!written&&!diagnostic)
323323
std::println(std::cerr,"mcpp: CI early status publication: {}",localDiagnostic);
324324
#endif
325325
return written;

0 commit comments

Comments
 (0)