Clean up

Author: myint

Makefile

@@ -14,11 +14,14 @@ check:
 		--disable=no-name-in-module \
 		--disable=protected-access \
 		--disable=raising-bad-type \
+		--disable=redefined-variable-type \
 		--disable=similarities \
 		--disable=too-few-public-methods \
 		--disable=too-many-branches \
 		--disable=too-many-locals \
 		--disable=too-many-statements \
+		--disable=wrong-import-order \
+		--disable=wrong-import-position \
 		./language-check \
 		$(wildcard ./language_check/*.py) \
 		$(wildcard *.py)

language_check/main.py

@@ -13,8 +13,9 @@
 
 
 def parse_args():
-    parser = argparse.ArgumentParser(description=__doc__.strip(),
-                                     prog='language-check')
+    parser = argparse.ArgumentParser(
+        description=__doc__.strip() if __doc__ else None,
+        prog='language-check')
     parser.add_argument('files', nargs='+',
                         help='plain text file or "-" for stdin')
     parser.add_argument('-c', '--encoding',

language_check/which.py

@@ -3,6 +3,7 @@
 """Cross-platform which command."""
 
 import os
+import sys
 
 
 __all__ = ['which']
@@ -72,5 +73,4 @@ def main():
 
 
 if __name__ == '__main__':
-    import sys
     sys.exit(main())

setup.py

@@ -6,6 +6,7 @@
 import glob
 import io
 import os
+import platform
 import re
 import shutil
 import subprocess
@@ -120,8 +121,7 @@ def __len__(self):
     ('metadata', 'requires-external'),
 ])
 
-# For environment markers
-import platform
+# For environment markers.
 assert platform
 
 
@@ -479,7 +479,7 @@ def copy_data(src, dst):
             path = os.path.join(py3k_path, fn)
             if not os.path.isfile(path):
                 continue
-            if not os.path.splitext(path)[1].lower() == '.py':
+            if os.path.splitext(path)[1].lower() != '.py':
                 continue
             new_path = os.path.join(py2k_path, fn)
             if copy(path, new_path):