fix: add WIFI_PRIVACY guard to savePreferences debug log - #291
Merged
Conversation
The savePreferences debug log is currently gated only by DEBUG_CAPTIVE_PORTAL, while other similar debug logs in the codebase (printActualSettings, onWifiSettingsChanged) also check WIFI_PRIVACY. Align the guard for consistency: change #ifdef to #if defined(DEBUG_CAPTIVE_PORTAL) && !defined(WIFI_PRIVACY). Bump version to 0.16.016-beta. Closes #290
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns /savePreferences serial debug output with the project’s WIFI_PRIVACY expectations by ensuring the debug log is suppressed when privacy mode is enabled, while also bumping the development version and documenting the fix in the changelog.
Changes:
- Guarded the
/savePreferencesdebug log with!defined(WIFI_PRIVACY)in addition toDEBUG_CAPTIVE_PORTAL. - Bumped the build revision from
015-betato016-beta. - Added a changelog entry for
v0.16.016-betadescribing the privacy-guard fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
CO2_Gadget_WIFI.h |
Updates the preprocessor guard so /savePreferences debug output won’t print when WIFI_PRIVACY is enabled. |
platformio.ini |
Version/revision bump to 016-beta to reflect the new build iteration containing the fix. |
CHANGELOG.md |
Documents the fix under the new v0.16.016-beta Unreleased entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One-line fix: change
#ifdef DEBUG_CAPTIVE_PORTALto#if defined(DEBUG_CAPTIVE_PORTAL) && !defined(WIFI_PRIVACY)on the savePreferences endpoint debug log.Why
The
/savePreferencesdebug log inCO2_Gadget_WIFI.h:1860is gated only byDEBUG_CAPTIVE_PORTAL, while other similar debug logs (printActualSettings(),onWifiSettingsChanged()) also respect theWIFI_PRIVACYflag. This aligns the guard for consistency.Files changed
CO2_Gadget_WIFI.h- line 1860: preprocessor guard fixplatformio.ini- version bump:015-beta->016-betaCHANGELOG.md- new entry for v0.16.016-betaCloses #290