Feature/sap hana client jar stage by Pri1235 · Pull Request #915 · mendix/cf-mendix-buildpack

Pri1235 · 2026-09-03T08:05:50Z

Added SAP HANA client JAR staging to the CF Mendix buildpack — fetches ngdbc-2.29.11.jar from the Mendix CDN when INCLUDE_SAP_HANA_CLIENT is set.

When SAP_HANA_CLIENT_ENABLED is set to a non-empty value, the buildpack fetches ngdbc.jar from Maven Central and places it in model/lib/userlib/ so the Mendix runtime can load it via the project-userlib classpath. SAP_HANA_CLIENT_URL can be set to override the default Maven Central URL (e.g. to point to a CDN-hosted version or a different ngdbc version). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

If fetching the HANA client JAR fails, log a warning and continue deployment instead of failing the staging process. Also log the JAR filename (including version) and destination path on success. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…citly Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

mayankmendix · 2026-09-03T16:11:38Z

+    version_url = util.get_blobstore_url(f"{_SAP_HANA_CLIENT_CDN_PREFIX}/version.txt")
+    resp = req.get(version_url, timeout=10)
+    resp.raise_for_status()
+    return f"ngdbc-{resp.text.strip()}.jar"


remove the hardcoded string part to line number 84. Update this function as _get_hana_jar_version().
This way string manipulation will be in one place.

mayankmendix · 2026-09-03T16:19:13Z

    metering.stage(BUILDPACK_DIR, BUILD_DIR, CACHE_DIR)
    database.stage(BUILDPACK_DIR, BUILD_DIR)
    runtime.stage(BUILDPACK_DIR, BUILD_DIR, CACHE_DIR)
+    runtime.stage_hana_client(BUILD_DIR)


shouldn't stage_hana_client be called from inside stage method, of runtime?

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…hana_jar_version Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

… prefix Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

mayankmendix · 2026-09-15T12:14:33Z

  ],
 ```

+#### SAP HANA JDBC Client JAR


Name is as "SAP HANA Client" only.
Also in the description below.

mayankmendix · 2026-09-15T12:16:49Z

+    return os.environ.get("MXRUNTIME_IncludeSAPHanaClient", "").strip().lower() == "true"
+
+
+def _get_hana_jar_version():


We do not need this as a separate method. Can be merged into stage_hana_client

mayankmendix · 2026-09-15T12:18:48Z

    return False


+_SAP_HANA_CLIENT_CDN_PREFIX = util.BLOBSTORE_BUILDPACK_DEFAULT_PREFIX + "sap-hana-client"


Do not need to be a global constant. Can be a local constant for method stage_hana_client

- Inline _is_sap_hana_client_enabled and _get_hana_jar_version into _stage_hana_client - Remove module-level _SAP_HANA_CLIENT_CDN_PREFIX constant; use local variable instead - Move requests import to top-level - Rename README section from "SAP HANA JDBC Client JAR" to "SAP HANA Client" Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* added the metering code * added logging * added the sap metering sidecar * updated the auth token usage * updated the comments * updated the env vars * fix: update cryptography to 46.0.7 to address CVE-2026-39892 - Updated cryptography from 46.0.5 to 46.0.7 - Fixes buffer overflow vulnerability in non-contiguous buffer handling - Regenerated requirements.txt with Python 3.10 - All unit tests passing (184 passed) - All linting checks passing * Bumped the cryptography module version to latest 47.0.0 * Fix CVE-2026-25645 and CVE-2026-34073 by upgrading requests and cryptography Updated requests from 2.32.5 to 2.33.1 to address CVE-2026-25645. Updated cryptography from 46.0.5 to 47.0.0 to address CVE-2026-34073. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * Security/upgrade requests urllib3 CVE fix (#894) * Security: Upgrade requests to 2.34.2 and urllib3 to 2.7.0 Fixes high-severity CVEs: - CVE-2026-25645 (requests): Fixed in 2.33.0+ - GHSA-mf9v-mfxr-j63j (urllib3): Streaming API decompression issue - GHSA-qccp-gfcp-xxvc (urllib3): Cross-origin redirect header leakage Changes: - requests: 2.32.5 → 2.34.2 - urllib3: 2.6.3 → 2.7.0 - charset-normalizer: 2.0.3 → 3.4.7 (transitive) - idna: 3.10 → 3.15 (transitive) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * Fixes high-severity CVEs: - CVE-2026-25645 (requests): Fixed in 2.33.0+ - GHSA-mf9v-mfxr-j63j (urllib3): Streaming API decompression issue - GHSA-qccp-gfcp-xxvc (urllib3): Cross-origin redirect header leakage --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> * (fix) add typing extension lib (#898) * Update requirements.txt * Update requirements.in * Expand static files caching (#901) Support static files caching * Security: Fix CVE-2026-45409 (idna) and GHSA-537c-gmf6-5ccf (cryptogr… (#902) Security: Fix CVE-2026-45409 (idna) and GHSA-537c-gmf6-5ccf (cryptography) Upgrades dependencies to address high-severity vulnerabilities: - cryptography 47.0.0 → 48.0.1: Fixes vulnerable OpenSSL in wheels - idna 3.10 → 3.15: Fixes DoS vulnerability in IDNA encoding CVE-2026-45409: idna versions prior to 3.15 were vulnerable to DoS attacks via specially crafted inputs to idna.encode() function. GHSA-537c-gmf6-5ccf: cryptography wheels prior to 48.0.1 included a statically linked copy of OpenSSL with security vulnerabilities. * Security: Upgrade nginx from 1.26.1 to 1.30.4 to fix CVE-2025-23419 a… (#909) Security: Upgrade nginx from 1.26.1 to 1.30.4 to fix CVE-2025-23419 and CVE-2026-42945 Co-authored-by: bhavin.shah <bhavin.shah@mendix.com> * Fix CVE-2026-69247(cryptography)andCVE-2026-59939(httplib2) (#907) Co-authored-by: Piyush <piyush.tiwari@mendix.com> Co-authored-by: mayankmendix <60148863+mayankmendix@users.noreply.github.com> * Add deprecation warning for Cloud Foundry Buildpack (#910) Added a warning about the deprecation of the Cloud Foundry Buildpack for Mendix 12 and future Runtime versions. * Fix PostgreSQL metrics query to filter by application database (#914) Co-authored-by: Bhavin <bhavin.shah@mendix.com> * Feature/sap hana client jar stage (#915) Added SAP HANA client JAR staging support * Skip staging SAP HANA client JAR if already present in userlib or vendorlib (#916) Skip staging SAP HANA client JAR if already present in userlib or vendorlib * Add RDS ap-southeast-7 support (#917) * Add RDS ap-southeast-7 support * Fix cert vulnerability (#920) * Update requirements.in for certifi * Update requirements.txt for certifi * Update dependencies.yml for JDK patch versions --------- Co-authored-by: bhavin.shah <bhavin.shah@mendix.com> Co-authored-by: priyal.chawda@mendix.com <priyal.chawda@mendix.com> Co-authored-by: Piyush <piyush.tiwari@mendix.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> Co-authored-by: Bhavin Shah <162097397+bhavinshah-mendix@users.noreply.github.com> Co-authored-by: Sanny Ramirez <sai.ramirez.umak@gmail.com> Co-authored-by: EnasAbdelrazek <96430281+EnasAbdelrazek@users.noreply.github.com> Co-authored-by: Bhavin Shah <162097397+bhavinshahM@users.noreply.github.com> Co-authored-by: PiyushTiwari-LowCode <106152452+PiyushTiwari-LowCode@users.noreply.github.com> Co-authored-by: Mário Serrador <61971372+mruiserrmendix@users.noreply.github.com> Co-authored-by: Priyal Chawda <86288192+Pri1235@users.noreply.github.com>

priyal.chawda@mendix.com and others added 10 commits September 2, 2026 13:06

Use Mendix Nexus proxy for SAP HANA client JAR

844c93c

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Use Mendix CDN for SAP HANA client JAR

3b36766

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Fix SAP HANA client JAR CDN artifact path

9d9f109

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Update SAP HANA client JAR CDN path to sap-hana-client subdirectory

4ecbf56

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Use private getter functions for SAP HANA client env vars

a7e01e4

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Remove unused SAP_HANA_CLIENT_URL override, simplify stage_hana_client

b18c544

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Rename env var to INCLUDE_SAP_HANA_CLIENT, check for true value expli…

f684e3c

…citly Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Fetch SAP HANA JAR via version.txt from CDN, remove dependency entry

c927cf9

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

mayankmendix reviewed Sep 3, 2026

View reviewed changes

Comment thread buildpack/core/runtime.py Resolved

mayankmendix reviewed Sep 3, 2026

View reviewed changes

priyal.chawda@mendix.com and others added 3 commits September 3, 2026 21:56

Rename env var to MXRUNTIME_IncludeSAPHanaClient, add README docs

5375066

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Address review: move hana staging into runtime.stage, rename to _get_…

b2078b4

…hana_jar_version Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Use util.BLOBSTORE_BUILDPACK_DEFAULT_PREFIX to construct SAP HANA CDN…

48ab8bc

… prefix Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

mayankmendix reviewed Sep 15, 2026

View reviewed changes

Pri1235 force-pushed the feature/sap-hana-client-jar-clean branch from 064fa09 to 203dc55 Compare September 16, 2026 08:35

mayankmendix changed the title ~~Feature/sap hana client jar clean~~ Feature/sap hana client jar stage Sep 16, 2026

mayankmendix approved these changes Sep 16, 2026

View reviewed changes

Merge branch 'develop' into feature/sap-hana-client-jar-clean

4946b23

mayankmendix merged commit 7ae5435 into mendix:develop Sep 16, 2026
26 checks passed

Navigation Menu

Repository navigation

Feature/sap hana client jar stage - #915

Feature/sap hana client jar stage#915
mayankmendix merged 15 commits into
mendix:developfrom
Pri1235:feature/sap-hana-client-jar-clean

Pri1235 commented Sep 3, 2026

Uh oh!

mayankmendix Sep 3, 2026

Uh oh!

Uh oh!

mayankmendix Sep 3, 2026 •

edited

Loading

Uh oh!

mayankmendix Sep 15, 2026

Uh oh!

mayankmendix Sep 15, 2026

Uh oh!

mayankmendix Sep 15, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		return os.environ.get("MXRUNTIME_IncludeSAPHanaClient", "").strip().lower() == "true"


		def _get_hana_jar_version():

		return False


		_SAP_HANA_CLIENT_CDN_PREFIX = util.BLOBSTORE_BUILDPACK_DEFAULT_PREFIX + "sap-hana-client"

Conversation

Pri1235 commented Sep 3, 2026

Uh oh!

mayankmendix Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mayankmendix Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mayankmendix Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

mayankmendix Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

mayankmendix Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mayankmendix Sep 3, 2026 •

edited

Loading