Skip to content

Commit dddaeb4

Browse files
committed
fix: update after test
1 parent c5a9bc6 commit dddaeb4

7 files changed

Lines changed: 24 additions & 15 deletions

File tree

‎packages/modules/data-widgets/CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66

77
## [Unreleased]
88

9+
### Fixed
10+
11+
- We fixed an issue where the pagination text in Data Grid 2 and Gallery was hard to read in dark themes. The pagination text now follows the theme's default font color, so the `$caption-color` variable no longer applies to it. To keep a custom pagination color, set `color` on `.pagination-bar` in your theme.
12+
913
## [3.11.8] DataWidgets - 2026-10-22
1014

1115
### Datagrid

‎packages/modules/data-widgets/src/themesource/datawidgets/web/_datagrid-dropdown-filter.scss‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,13 @@ $root: ".widget-dropdown-filter";
3838
--wdf-popover-z-index: 50;
3939
--wdf-popover-shadow: 0px 0px var(--wdf-outer-spacing) 0px var(--shadow-color-border, rgba(0, 0, 0, 0.2));
4040
--wdf-bd-radius: var(--dropdown-border-radius, 7px);
41-
--wdf-menu-bg-color: var(--label-info-color, $color-base);
41+
--wdf-menu-bg-color: var(--label-info-color, #{$color-base});
4242
--wdf-menu-max-height: var(--dropdown-menu-max-height, 320px);
4343
--wdf-menu-item-padding: 6px 10px;
44-
--wdf-highlighted-bg-color: var(--color-default-light, $color-default-light);
45-
--wdf-selected-bg-color: var(--color-primary-lighter, $color-primary-lighter);
44+
--wdf-highlighted-bg-color: var(--color-default-light, #{$color-default-light});
45+
--wdf-selected-bg-color: var(--color-primary-lighter, #{$color-primary-lighter});
4646
--wdf-button-spacing: 8px;
47-
--wdf-color: var(--font-color-default, $gray-dark);
47+
--wdf-color: var(--font-color-default, #{$gray-dark});
4848
--wdf-state-icon-size: 16px;
4949
--wdf-toggle-width: calc(4px + var(--wdf-state-icon-size) + var(--wdf-button-spacing));
5050
--wdf-toggle-inline-end: var(--wdf-toggle-width);
@@ -246,7 +246,7 @@ $root: ".widget-dropdown-filter";
246246
}
247247

248248
:where(#{$root}.variant-select[data-empty]) {
249-
--wdf-input-placeholder-color: var(--form-input-placeholder-color, $form-input-placeholder-color);
249+
--wdf-input-placeholder-color: var(--form-input-placeholder-color, #{$form-input-placeholder-color});
250250
#{$root}-toggle {
251251
color: var(--wdf-input-placeholder-color);
252252
}

‎packages/modules/data-widgets/src/themesource/datawidgets/web/_gallery-design-properties.scss‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,17 +74,17 @@
7474

7575
// Grid spacing small
7676
.widget-gallery.widget-gallery-gridgap-small {
77-
--gallery-gap: var(--spacing-small, $spacing-small);
77+
--gallery-gap: var(--spacing-small, #{$spacing-small});
7878
}
7979

8080
// Grid spacing medium
8181
.widget-gallery.widget-gallery-gridgap-medium {
82-
--gallery-gap: var(--spacing-medium, $spacing-medium);
82+
--gallery-gap: var(--spacing-medium, #{$spacing-medium});
8383
}
8484

8585
// Grid spacing large
8686
.widget-gallery.widget-gallery-gridgap-large {
87-
--gallery-gap: var(--spacing-large, $spacing-large);
87+
--gallery-gap: var(--spacing-large, #{$spacing-large});
8888
}
8989

9090
// Pagination alignment

‎packages/modules/data-widgets/src/themesource/datawidgets/web/_gallery.scss‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ $root: ".widget-gallery" !default;
2424
}
2525

2626
.widget-gallery {
27-
--gallery-gap: var(--spacing-small, $gallery-gap);
27+
--gallery-gap: var(--spacing-small, #{$gallery-gap});
2828

2929
.widget-gallery-items {
3030
display: grid;

‎packages/modules/data-widgets/src/themesource/datawidgets/web/_pagination-bar.scss‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
justify-content: flex-end;
44
white-space: nowrap;
55
align-items: baseline;
6-
color: $caption-color;
6+
color: var(--font-color-default, $font-color-default);
77

88
.paging-status {
99
padding: 0 8px 0;

‎packages/modules/data-widgets/src/themesource/datawidgets/web/_three-state-checkbox.scss‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ input[type="checkbox"].three-state-checkbox {
8080
&:indeterminate:disabled:before,
8181
&:checked:disabled:before {
8282
border-color: transparent;
83-
background-color: var(--brand-primary-200, rgba($brand-primary, 0.4));
83+
background-color: var(--brand-primary-200, color-mix(in srgb, $brand-primary 40%, transparent));
8484
}
8585

8686
&:disabled:after {

‎packages/modules/data-widgets/src/themesource/datawidgets/web/variables.scss‎

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
// Atlas UI compatible variable naming for data widgets
2-
32
// Brand colors
43
$brand-primary: #264ae5 !default;
54
$brand-danger: #e33f4e !default;
@@ -9,7 +8,7 @@ $color-contrast: #000 !default;
98
$color-base: #fff !default;
109
$gray-primary: #ced0d3 !default;
1110
$brand-default: $gray-primary !default;
12-
$color-default-lighter: mix($brand-default, $color-base, 10%) !default;
11+
$color-default-lighter: #fafafb !default;
1312

1413
// Background
1514
$bg-color: $color-default-lighter !default;
@@ -20,12 +19,14 @@ $hover-color: #f8f8f8 !default;
2019
$selected-color: #dadcde !default;
2120
$label-info-color: $color-base !default;
2221
$color-default-light: $grid-bg-hover !default;
22+
$color-primary-light: #d4dbfa !default;
2323
$color-primary-lighter: $brand-light !default;
2424

2525
// Text and icon colors
26+
$gray-lighter: #f8f8f8 !default;
2627
$gray-dark: #606671 !default;
2728
$gray-darker: #3b4251 !default;
28-
$caption-color: #0a1325 !default;
29+
$font-color-default: #0a1325 !default;
2930
$form-input-placeholder-color: #757575 !default;
3031
$form-input-border-color: $brand-primary !default;
3132
$btn-primary-color: $color-base !default;
@@ -43,12 +44,16 @@ $spacing-medium: 16px !default;
4344
$spacing-large: 24px !default;
4445
$spacing-larger: 32px !default;
4546

47+
// Breakpoints (lengths, used in media queries)
48+
$screen-md: 768px !default;
49+
$screen-lg: 992px !default;
50+
4651
// Gallery specific spacing
4752
$gallery-gap: $spacing-small !default;
4853

4954
// Effects and animations
5055
$dragging-color-effect: rgba(10, 19, 37, 0.8) !default;
51-
$shadow-color: rgba($gray-primary, 0.66) !default;
56+
$shadow-color: rgba(231, 231, 233, 0.66) !default;
5257
$export-alert-box-shadow: 0px 4px 4px 0px rgba(0, 0, 0, 0.25) !default;
5358
$skeleton-background: linear-gradient(90deg, rgba(194, 194, 194, 0.2) 0%, #d2d2d2 100%) !default;
5459

0 commit comments

Comments
 (0)