Repository navigation
[WC-3570]: fix(popup-menu-web): make pop-up menu keyboard accessible - #2447
Merged
Merged
Conversation
r0b1n
force-pushed
the
fix/popup-menu-keyboard-accessibility
branch
from
October 7, 2026 10:41
0803c8f to
ca6299b
Compare
r0b1n
marked this pull request as ready for review
October 7, 2026 12:43
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
r0b1n
force-pushed
the
fix/popup-menu-keyboard-accessibility
branch
from
October 19, 2026 12:35
da8d3d0 to
d5eea75
Compare
gjulivan
previously approved these changes
Oct 29, 2026
r0b1n
force-pushed
the
fix/popup-menu-keyboard-accessibility
branch
from
November 12, 2026 09:54
d5eea75 to
c46af52
Compare
This comment has been minimized.
This comment has been minimized.
The menu couldn't be opened or navigated from the keyboard: Mendix buttons prevent default on Enter/Space, so the trigger never opened, and items weren't focusable. Follows the WAI-ARIA menu button pattern, including nested menus as submenus.
…ard e2e - Stop the keyup of an Escape the menu handled. The Mendix client closes pop-up pages on the Escape keyup, so a menu on a pop-up page closed the page too. - Close the whole menu on Shift+Tab out of a submenu even when it comes right after the submenu opened, by checking whether focus came from inside the submenu instead of its re-rendered open state. - Add keyboard e2e tests for the new Keyboard test page. - Update the OpenSpec change docs to describe the current behavior only.
…n empty menu Enter and Space on a text-entry element inside the trigger no longer toggle the menu, and a click into it opens the menu without moving focus. A menu without visible items no longer opens, and an empty submenu isn't exposed on its parent item.
Correct the presentational wording for content inside custom items, document the text box trigger, empty menu and parent item action behavior, and track the open findings in tasks.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
AI Code Review
What was reviewed
Skipped (out of scope): snapshots beyond a sanity check, lockfiles, CI: pending: Run automated end-to-end tests, Run code quality check, sigridci · unrelated failures: security/snyk (external scanner; the code and license Snyk checks pass) Questions
Positives
|
leonardomendix
approved these changes
Nov 16, 2026
r0b1n
enabled auto-merge
November 17, 2026 12:07
iobuhov
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Draft: E2E tests pass locally in Chromium. Still needs Firefox and Safari runs and manual screen reader testing.
The pop-up menu couldn't be used with a keyboard. A Mendix Action Button prevents default on Enter/Space, so Floating UI's
useClickignored the keydown and no native click followed. Menu items weren't focusable at all.This follows the WAI-ARIA APG Menu Button + Menu pattern. The full design and its rationale are in
openspec/changes/fix-popup-menu-keyboard-accessibility/design.md.defaultPrevented.role="menu"/menuitem, a roving tabindex viauseListNavigation(Up/Down/Home/End, wrap-around), and Enter/Space run the same action as a click. Escape closes the level that contains focus and returns focus.FloatingFocusManager'scloseOnFocusOutcloses the menu on focus-out. SmallonFocushandlers cover the cases Floating UI excuses: focus landing on the trigger, or on a parent item from a submenu. The parent item asks the submenu whether focus came from inside it rather than reading its open state, which updates a render later and missed a fast Shift+Tab.No XML or property changes.
Tests
src/__tests__/PopupMenu.keyboard.spec.tsx.e2e/PopupMenu.keyboard.spec.js, run against the newKeyboardpage (/p/keyboard) andKeyboardPopuppop-up page, pushed to thepopupmenu-webbranch ofmendix/testProjects(59b8d3c). They replace the keyboard tests previously added toe2e/PopupMenu.spec.js.focus()calls.What should be covered while testing?