Repository navigation
[CRAFTING] fix(rich-text-web): keep text color, font family and size in class style mode - #2454
Closed
samuelreichert wants to merge 1 commit into
Closed
samuelreichert wants to merge 1 commit into
samuelreichert wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
This was referenced Oct 6, 2026
samuelreichert
force-pushed
the
test/rich-text-unit-coverage
branch
from
October 12, 2026 09:11
be0a685 to
a153c39
Compare
…yle mode Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
samuelreichert
force-pushed
the
fix/rich-text-class-mode-reload
branch
from
October 12, 2026 12:58
b593a76 to
79913aa
Compare
Contributor
AI Code Review
What was reviewed
Skipped (out of scope): CI checks could not be fetched automatically (permission denied), but the PR description states lint and the full package test suite pass. Positives
|
Contributor
Author
|
Superseded by #2495, which combines this fix with the other Rich Text fixes on top of the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
With Style data format = Class (strict CSP mode), text color, font family and font size were lost when saved content was loaded again. This is data loss for every app using class mode.
Root cause: in class mode these marks are saved as
<span data-text-color|data-font-family|data-font-size class="has-…">with nostyleattribute. Tiptap'sTextStylemark only parses a<span>that has astyleattribute (@tiptap/extension-text-style), so these spans were dropped on load.Fix: a new
TextStyleClassextendsTextStyle. In class mode it adds one parse rule for spans that carry these data attributes. Inline mode keeps the original rules unchanged, and highlight and alignment were already unaffected. The extensions' value sanitising is untouched.The change was written test-first: the new regression test failed before the fix. Lint and the full package test suite pass, and there is a CHANGELOG entry under
[Unreleased].Note: Font size is stored without its unit in class mode (
18, not18px); that is existing behaviour and unchanged here.Based on
main(rebased after #2453 was merged).What should be covered while testing?
style.🤖 Generated with Claude Code